Skip to content

Cleanup contents of util #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Cleanup contents of util #127

merged 2 commits into from
Oct 20, 2017

Conversation

donny-dont
Copy link

A number of functions in util.dart aren't used now. Those are now removed. Formatted the file accordingly.

writeStreamToSink and isPlainAscii moved into the multipart implementation at 2097129

@nex3
Copy link
Member

nex3 commented Oct 20, 2017

I'm not sure I see the logic behind moving writeStreamToSink() and isPlainAscii() out of the utils directory. They seem like pretty generic utilities to me.

@donny-dont
Copy link
Author

@nex3 they weren't being used by anything outside of MultipartBody. Also wasn't sure if there was something in async that might be a replacement for writeStreamToSink.

@nex3
Copy link
Member

nex3 commented Oct 20, 2017

they weren't being used by anything outside of MultipartBody.

I think a better criterion for utils is "Stuff whose use is not specific to the place(s) where it's used", rather than "Stuff that's used in multiple places".

Also wasn't sure if there was something in async that might be a replacement for writeStreamToSink.

I don't know of anything that specifically writes without closing the sink.

@nex3 nex3 merged commit 441963f into dart-lang:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants