Modify context variable naming #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
suggested changes
Oct 27, 2017
lib/browser_client.dart
Outdated
| /// [HttpRequest] values through [Request.context]. | ||
| /// | ||
| /// * `http.html.with_credentials` is a boolean value, defaulting to `false` | ||
| /// that corresponds to [HttpRequest.withCredentials]. |
There was a problem hiding this comment.
I'd rather document these in terms of their semantics, rather than in terms of their implementation. Talk about what setting the context variables do.
lib/browser_client.dart
Outdated
| @@ -23,6 +23,12 @@ import 'src/response.dart'; | |||
| /// unable to directly set some headers, such as `content-length`. It is also | |||
| /// unable to stream requests or responses; a request will only be sent and a | |||
| /// response will only be returned once all the data is available. | |||
| /// | |||
| /// [BrowserClient] allows setting values directly on the underlying | |||
| /// [HttpRequest] values through [Request.context]. | |||
nex3
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated naming scheme and wrote some documentation around it.