-
Notifications
You must be signed in to change notification settings - Fork 213
[records] Disambiguate metadata annotation arguments and record types. #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we please not do the
part? Currently the parser does not have to worry about comments at all. In fact it's an option to the scanner to not save them at all to save memory and time. In fact that's what the CFE does. We don't need them and don't waste time and space on them. From #2469 (comment)
Can we have that instead please? |
accepted/future-releases/records/records-feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/records/records-feature-specification.md
Outdated
Show resolved
Hide resolved
# Conflicts: # accepted/future-releases/records/records-feature-specification.md
# Conflicts: # accepted/future-releases/records/records-feature-specification.md
I've updated the proposal to clarify that the parser changes are not language versioned. Reviewer friends, does this look ready to land? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # accepted/future-releases/records/records-feature-specification.md
Fix #2469.