Skip to content

[records] Disambiguate metadata annotation arguments and record types. #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

munificent
Copy link
Member

Fix #2469.

@jensjoha
Copy link

jensjoha commented Sep 29, 2022

Can we please not do the

Comments do not count as whitespace,
nor do whitespace characters in comments. The newline at the end of a line
comment *does* count as whitespace.

part?

Currently the parser does not have to worry about comments at all. In fact it's an option to the scanner to not save them at all to save memory and time. In fact that's what the CFE does. We don't need them and don't waste time and space on them.

From #2469 (comment)

I'm very tempted to say that if the next source token (ignoring comments and whitespace) after the identifier does not start right where the identifier ends, it's not part of the annotation. So no comments either.

Can we have that instead please?

# Conflicts:
#	accepted/future-releases/records/records-feature-specification.md
# Conflicts:
#	accepted/future-releases/records/records-feature-specification.md
@munificent
Copy link
Member Author

I've updated the proposal to clarify that the parser changes are not language versioned. Reviewer friends, does this look ready to land?

Copy link
Member

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	accepted/future-releases/records/records-feature-specification.md
@munificent munificent merged commit f1c8c2c into master Oct 26, 2022
@munificent munificent deleted the disambiguate-metadata branch October 26, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[records] parse errors when trying to annotate a record type class field
4 participants