With "Unquoted Imports" disallow unquoted part of library names. #4262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
Feb 12, 2025
accepted/future-releases/unquoted-imports/feature-specification.md
Outdated
Show resolved
Hide resolved
lrhn
approved these changes
Feb 12, 2025
accepted/future-releases/unquoted-imports/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/unquoted-imports/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/unquoted-imports/feature-specification.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4038, Lasse suggests that we shouldn't allow unquoted
part ofdirectives but change what they mean to be package references since that will likely just break silently and confuse users. Unquoted imports (with the new proposed semantics) in part directives aren't really useful anyway since parts should always be in the same package and the quoted syntax is shorter for that.So this PR changes the proposal to not apply the new syntax to
partandpart ofdirectives. It also makes a language versioned breaking change to remove support for unquoted library names inpart ofdirectives entirely since the syntax is long deprecated, problematic, and would become very confusing in the context of other unquoted imports.@dart-lang/language-team, PTAL since this proposal is already accepted so a change should be run by the whole team.
Fix #4038.