Skip to content

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented Aug 1, 2019

The feature spec does not explicitly make accesses to static members using explicit extension member syntax (like E(e).staticMember) an error, it just says that a static member can be accessed using the normal static member syntax E.staticMember.

This PR changes the rule for overriding access (like E(e).m) such that it is explicitly mentioned that the member (m) must be an extension instance member.

Copy link
Member

@leafpetersen leafpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTM

@leafpetersen
Copy link
Member

Is this waiting on an LGTM from @lrhn ?

@eernstg
Copy link
Member Author

eernstg commented Aug 15, 2019

Yes, I just wanted buy-in from Lasse. May come any minute.

@lrhn
Copy link
Member

lrhn commented Aug 15, 2019

LGTM.

@eernstg eernstg merged commit d30e0df into master Aug 15, 2019
@eernstg eernstg deleted the clarify_static_access_aug19 branch August 15, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants