-
Notifications
You must be signed in to change notification settings - Fork 213
Adding feature specification for generalized typedefs #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
197fa5b
Adding feature specification
eernstg 3b2755b
Review response
eernstg ab96711
Added a couple of missing words
eernstg 4db313d
Clarification
eernstg aa306a5
Added extra requirement: When bounds are satisfied the denoted type m…
eernstg e293c97
Typo
eernstg d8ec461
Review response
eernstg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
149 changes: 149 additions & 0 deletions
149
accepted/future-releases/generalized-typedef-2018/feature-specification.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,149 @@ | ||
# Design Document for Generalized Type Aliases 2018. | ||
|
||
Author: [email protected] (@eernst). | ||
|
||
Version: 0.1. | ||
|
||
|
||
## Motivation and Scope | ||
|
||
Parameterized types in Dart can be verbose. An example is here: | ||
|
||
```dart | ||
Map<ScaffoldFeatureController<SnackBar, SnackBarClosedReason>, | ||
SnackBar> | ||
``` | ||
|
||
Such verbose types may be needed repeatedly, and there may also be a need | ||
for several different variants of them, only differing in | ||
specific subterms. For instance, we might also need this one: | ||
|
||
```dart | ||
Map<ScaffoldFeatureController<SandwichBar, SandwichBarClosedReason>, | ||
SandwichBar> | ||
``` | ||
|
||
This type is unlikely to work as intended if the second type argument of | ||
`Map` is changed to `SnackBar`, but such mistakes could easily happen | ||
during development. It may not even be easy to detect exactly where the | ||
mistake occurred, in cases where the erroneous type is used in some | ||
declaration, and expressions whose types depend on that declaration | ||
unexpectedly get flagged as compile-time errors, or the IDE completions | ||
in such expressions fail to list some of the expected choices. | ||
|
||
This document describes how type aliases are generalized in Dart 2.2 | ||
to make such verbose types more concise and consistent. | ||
|
||
|
||
## Feature Specification | ||
|
||
The precise definition of the changes is given in the language | ||
specification, with a proposed form in | ||
[this CL](https://dart-review.googlesource.com/c/sdk/+/81414). | ||
The following sections summarize the changes. | ||
|
||
|
||
### Syntax | ||
|
||
The grammar is modified as follows in order to support this feature: | ||
|
||
``` | ||
typeAlias ::= | ||
metadata 'typedef' typeAliasBody | | ||
metadata 'typedef' identifier typeParameters? '=' type ';' // CHANGED | ||
``` | ||
|
||
*The modification is that a type alias declaration of the form that uses | ||
`=` can define the type alias to denote any type, not just a function | ||
type.* | ||
|
||
|
||
### Static Analysis | ||
|
||
There is no change in the treatment of existing syntax, so we describe only | ||
the treatment of syntactic forms that can be new when this feature is added. | ||
|
||
The effect of a non-generic type alias declaration of the form that uses | ||
`=` with name `F` is to bind the name `F` in the library scope of the | ||
enclosing library to the type denoted by the right hand side of `=` in that | ||
declaration. | ||
|
||
*This is not new, but it applies to a larger set of situations now that the | ||
right hand side can be any type. Let us call that type on the right hand | ||
side `T`. This means that `F` can be used as a type annotation, and the | ||
entity which is given type `F` is considered to have type `T`, with the | ||
same meaning as in the declaration of `F` (even if some declaration in the | ||
current library gives a new meaning to an identifier in `T`).* | ||
|
||
The effect of a generic type alias declaration of the form | ||
|
||
```dart | ||
typedef F<X1 extends B1 .. Xk extends Bk> = T; | ||
``` | ||
|
||
where metadata is omitted but may be present, is to bind the name `F` in | ||
the library scope of the enclosing library to a mapping from type argument | ||
lists to types, such that a parameterized type of the form `F<T1..Tk>` is | ||
an application of that mapping that denotes the type `[T1/X1 .. Tk/Xk]T`. | ||
|
||
Let _F_ be a generic type alias of the form that uses `=` with type | ||
parameter declarations | ||
_X<sub>1</sub> extends B<sub>1</sub> .. X<sub>k</sub> extends B<sub>k</sub>_. | ||
It is a compile-time error unless satisfaction of the declared bounds | ||
_B<sub>1</sub> .. B<sub>k</sub>_ implies that the right hand side is | ||
regular-bounded, and all types that occur as subterms of the right hand | ||
side are well-bounded. | ||
Any self reference in a type alias, either directly or recursively via another | ||
type alias, is a compile-time error. | ||
|
||
Let `F<T1..Tn>` be a parameterized type where `F` denotes a declaration of | ||
the form | ||
```dart | ||
typedef F<X1 extends B1 .. Xk extends Bk> = T; | ||
``` | ||
where metadata is omitted but may be present. It is a compile-time error if | ||
`n != k` and it is a compile-time error if `F<T1..Tn>` is not well-bounded. | ||
|
||
*These errors are not new, but they apply to a larger set of situations now | ||
that the right hand side can be any type.* | ||
|
||
When a `typeName` (*that is, `identifier` or `identifier.identifier`*) | ||
that resolves to a generic type alias declaration is used as a type or | ||
evaluated as an expression, it is subject to instantiation to bound. | ||
|
||
*This treatment of generic type aliases is again the same as it was | ||
previously, but it involves a larger set of types.* | ||
|
||
eernstg marked this conversation as resolved.
Show resolved
Hide resolved
eernstg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*Note that type aliases introduce types and not classes. Consequently, a | ||
type alias can **not** be used in a position where a class is expected: in the | ||
`extends`, `with`, `implements`, or `on` clause of a class or mixin | ||
declaration; for a static member access; or in an instance creation | ||
expression (`new F()`, `const F<int>()`). On the other hand, it **can** be | ||
used as a type annotation, as a type argument, as part of a function type | ||
or function signature, as a type literal, in an `on` clause of a `try` | ||
statement, in a type test (`e is F`), and in a type cast (`e as F`).* | ||
|
||
|
||
### Dynamic Semantics | ||
|
||
*The dynamic semantics relies on elaborations on the program performed | ||
during compilation. In particular, instantiation to bound has occurred, and | ||
hence some `typeName`s in the source code have been transformed into | ||
parameterized types, even when a type is used as an expression such that it | ||
would be a syntax error to actually add the type arguments explicitly in | ||
the source program. This means that every generic type alias receives | ||
actual type arguments at all locations where it is used. At run time it is | ||
also known that the program has no compile-time errors.* | ||
|
||
For dynamic type checks, type tests, and expression evaluations, an | ||
identifier `F` resolving to a non-generic type alias and a parameterized | ||
type `F<T1..Tk>` where `F` resolves to a generic type alias are treated | ||
identically to the same type checks and type tests performed with the type | ||
denoted by that identifier or parameterized type, and the evaluation of `F` | ||
respectively `F<T1..Tk>` as an expression works the same as evaluation of a | ||
fresh type variable bound to the denoted type. | ||
|
||
|
||
## Versions | ||
|
||
* Nov 6th, 2018, version 0.1: Initial version of this document. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the spec CL, such self-references must be absent after instantiate-to-bounds on the RHS. Effectively, I guess we will "evaluate" the RHS as a type expression and complain if it ever needs to refer to the LHS.