Skip to content

False positive for unintended_html_in_doc_comment #59506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sigurdm opened this issue Aug 9, 2024 · 2 comments
Closed

False positive for unintended_html_in_doc_comment #59506

sigurdm opened this issue Aug 9, 2024 · 2 comments
Assignees
@srawlins
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sigurdm
Copy link
Contributor

sigurdm commented Aug 9, 2024

Example:

/// `<` or `>`
foo() {}

I believe the angle brackets both are quoted.

image
@pq
Copy link
Member

pq commented Aug 9, 2024

/fyi @kallentu

@pq pq added linter-false-positive type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P2 A bug or feature request we're likely to work on labels Aug 9, 2024
@srawlins srawlins self-assigned this Aug 12, 2024
copybara-service bot referenced this issue Aug 12, 2024
@kallentu
[linter] Update documentation and regex for unintended_html_in_doc_co…
df283fd 
…mment lint.

Fix the documentation and make it more clear for users.
Added the allowlist of tags that won't be linted.

The regex for what is considered an unintended HTML tag has been updated.

Fixes https://github.com/dart-lang/linter/issues/5055
Bug: https://github.com/dart-lang/linter/issues/5050
Change-Id: I1963eb6878dd15d4a408be4ba6c2a4ba5f1d2e49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379519
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Lasse Nielsen <[email protected]>
@kallentu
Copy link
Member

Made a commit that changed the regex which matches for this lint.
Added a test for this case too, which now passes.
Should be good to close now.

@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-false-positive P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pq @srawlins @devoncarew @sigurdm @kallentu