-
Notifications
You must be signed in to change notification settings - Fork 68
[native_assets_cli] data assets #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I also found |
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@8cbef1d...9ba913c) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@8cbef1d...9ba913c) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Package rename is tracked in: |
Data assets are part of the protocol now, and the protocol is extensible. They have not been implemented in Dart and Flutter yet, but that's tracked by separate issues. |
Initially, we had the idea that the input and output for
build.dart
would be unstructured JSON/YAML, and that there would be multiple views on top of these JSONs. In this approach,package:native_assets_cli
would be one such view. And we would introduce other views for other types of assets (icons, localization) ...However, after some discussions with @mosuem, we realized that some of the things in the JSON would be better off shared:
BuildOutput
: the dependencies (used for caching -- whether build.dart should be reinvoked). This would also be required for resource shaking in localization.BuildConfig
the targetOS would likely be used for deciding what icons to bundle.If we add a concept of "data assets" to the native assets CLI, then we should reconsider the package name
package:native_assets_cli
to be something likepackage:build_script
instead. (Suggestion taken from @gaaclarke)Dart SDK tracking issue:
Flutter tracking issue:
hook/build.dart
Data assets support flutter/flutter#146264The text was updated successfully, but these errors were encountered: