Skip to content

Rename add_gradle_deps to something more indicating of adding jars #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HosseinYousefi opened this issue Apr 20, 2023 · 3 comments
Closed

Comments

@HosseinYousefi
Copy link
Member

          We could introduce some flag that combines the two like `add_gradle_deps` that can be `all`, `none`, `sources_only` and `jars_only`. I think I would mostly want to use `add_gradle_deps: 'all'`. Naming could be improved.

Originally posted by @HosseinYousefi in dart-archive/jnigen#234 (comment)

@HosseinYousefi
Copy link
Member Author

This would be a breaking change now that 0.5.0 is out. Moving it to 0.6.0...

@mahesh-hegde What do you think about the naming? I think we almost always want to have the source when we have it for generation because of the argument naming and javadocs, so the way config is set up needs to reflect this default.

@mahesh-hegde
Copy link
Contributor

I don't really have an opinion with naming. Anything is fine for me.

That said, It's not necessary to add android gradle sources when the code to bind is in project itself.

The JAR in class path however are also used by source summarizer, because it needs a clear picture of every class ever referred to in source.

For example when you refer to android.content.Intent in one of input source files, the javadoc tool need to know what's Intent class. For this, it suffices if Intent is given in the classPath of javadoc tool.

That's the other place class path is used, apart from ASM backend.

@HosseinYousefi HosseinYousefi transferred this issue from dart-archive/jnigen Nov 17, 2023
parlough pushed a commit to parlough/native that referenced this issue Apr 8, 2024
* WIP static functions

* Revert old code gen changes

* Refactor function code gen

* Arg and return conversions

* fix bugs

* Fix analysis, add more tests

* fmt

* Fix autorelease pool test

* Handle NS_RETURNS_RETAINED

* Daco's comments
@HosseinYousefi HosseinYousefi moved this to Backlog in JNIgen tracker Apr 11, 2024
@HosseinYousefi
Copy link
Member Author

Not important, there will be bigger changes to the gradle workflow after the introduction of proguard generation.

@HosseinYousefi HosseinYousefi closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in JNIgen tracker May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants