-
Notifications
You must be signed in to change notification settings - Fork 68
Rename add_gradle_deps to something more indicating of adding jars #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would be a breaking change now that 0.5.0 is out. Moving it to 0.6.0... @mahesh-hegde What do you think about the naming? I think we almost always want to have the source when we have it for generation because of the argument naming and javadocs, so the way config is set up needs to reflect this default. |
I don't really have an opinion with naming. Anything is fine for me. That said, It's not necessary to add android gradle sources when the code to bind is in project itself. The JAR in class path however are also used by source summarizer, because it needs a clear picture of every class ever referred to in source. For example when you refer to That's the other place class path is used, apart from ASM backend. |
* WIP static functions * Revert old code gen changes * Refactor function code gen * Arg and return conversions * fix bugs * Fix analysis, add more tests * fmt * Fix autorelease pool test * Handle NS_RETURNS_RETAINED * Daco's comments
Not important, there will be bigger changes to the gradle workflow after the introduction of proguard generation. |
Originally posted by @HosseinYousefi in dart-archive/jnigen#234 (comment)
The text was updated successfully, but these errors were encountered: