rename to jnigen

[devoncarew]

Hi - I'm not sure the intended lifetime of this package, but if we expect it to be around longer than the summer of code program, we should rename the repo and the package to jni_gen (from jnigen) to match our other repo names.

[mahesh-hegde]

jnigen is analog of ffigen for Java. (That's what I thought while writing the proposal for GSoC)

[devoncarew]

Gotcha, thanks for the background. However, we'll still want the Dart package to use standard pub naming conventions (https://dart.dev/tools/pub/pubspec#name - lowercase with underscores), and for the repo name to follow the package name.

[devoncarew]

Now that I look, I do see that ffigen is also not using pub conventions - https://github.com/dart-lang/ffigen/blob/master/pubspec.yaml#L5).

[mahesh-hegde]

I think it's fine for short names.

Also it's not used in source code, only run as a plugin from command line. I think consistency with existing plugin is a good idea. (ffigen is a mature package and I don't think name change will be good idea.)

[devoncarew]

I agree that changing ffigen would be unnecessarily expensive. Changing jnigen would be cheap however, and avoid us creating new packages that don't follow pub conventions.

[dcharkes]

I've hit the rename button. 🚀 (Sorry for breaking your bookmarks/PRs/etc. 😆)

@mahesh-hegde could you make a PR to rename the stub-project? (Or fold it into the PR that moves it.)

[devoncarew]

👍 - thanks!

[dcharkes]

As noted by @mit-mit and @lrhn this causes our command line invocations to be dart run jni_gen which is less usable than dart run jnigen. Maybe we should reconsider this decision.

The standard pub naming conventions seem to be conflicting with usable commandline commands. @jonasfj @devoncarew

[mahesh-hegde]

I think that's not a frequently run command and jni_gen is also fine. For comparison, the generator command for json_serializable is `dart run build_runner build`. Mahesh

…

On Mon, 22 Aug, 2022, 5:27 pm Daco Harkes, ***@***.***> wrote: As noted by @mit-mit <https://github.com/mit-mit> and @lrhn <https://github.com/lrhn> this causes our command line invocations to be dart run jni_gen which is less usable than dart run jnigen. Maybe we should reconsider this decision. The standard pub naming conventions seem to be conflicting with usable commandline commands. @jonasfj <https://github.com/jonasfj> @devoncarew <https://github.com/devoncarew> — Reply to this email directly, view it on GitHub <https://github.com/dart-lang/jni_gen/issues/3#issuecomment-1222253322>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALAKLFTSET75M4U5FNLVOU3V2NTMJANCNFSM52NEXE3Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mit-mit]

I worry especially about this due to mismatch between ffigen and jni_gen given these tools are likely to be used by the same users.

I think consistency between these is a LOT more important than consistency with other tools (like build_runner).

[mahesh-hegde]

Actually on top of this thread you can see me making the same argument. But then @devoncarew's point also made sense. Let's see any other arguments pros/cons come up in this discussion. Mahesh

…

On Mon, 22 Aug, 2022, 5:36 pm Michael Thomsen, ***@***.***> wrote: Reopened dart-lang/native#802 <https://github.com/dart-lang/jni_gen/issues/3>. — Reply to this email directly, view it on GitHub <https://github.com/dart-lang/jni_gen/issues/3#event-7232204755>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALAKLFSKQAOFOQOAZEHAUF3V2NUOBANCNFSM52NEXE3Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[devoncarew]

I'm a little less concerned here than I was earlier; jnigen gives us consistently with ffigen, and, it seems like a more natural name for a tool (more natural than jni_gen).

[dcharkes]

@mahesh-hegde

When would be the best moment to change the repository name, again?
And when would be the best moment to change the jni_gen folder to jnigen again?
So that we can create the least amount of extra work. 😅