Skip to content

[native_assets_cli] Disallow any other keys in the output file #94

Open
@dcharkes

Description

@dcharkes

In a discussion with @jonasfj earlier, we discussed to disallow any other keys in the output file in order to ensure package authors implementing the protocol themselves don't prevent us from adding keys later.

Implementing this would mean that end users always need the newest Dart / Flutter SDK if the native_assets_cli used in their build.dart is new, otherwise it might output a key that is not yet accepted by the Dart / Flutter SDK. This might be an issue while we develop the package because we need to release new versions of native_assets_cli and native_assets_builder on pub before they can roll into flutter_tools (it doesn't use DEPS, but a normal pubspec.yaml). And it takes a couple of months for commits to reach Flutter and Dart stable.

Essentially, disallowing other keys in the output file makes adding keys to the output file a breaking change. I believe it's better to avoid causing breaking changes. So maybe it's better to not disallow other keys in the output file. wdyt @jonasfj

Activity

jonasfj

jonasfj commented on Jul 19, 2023

@jonasfj
Member

See comment #93 (comment)

added this to the Native Assets v1.x milestone on Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4A feature or bug we're unlikely to addresspackage:hooks

    Type

    No type

    Projects

    Status

    No status

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jonasfj@dcharkes

        Issue actions

          [native_assets_cli] Disallow any other keys in the output file · Issue #94 · dart-lang/native