[native_toolchain_c] Default handling for PIC/PIE compiler flags #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
approved these changes
Sep 4, 2023
|
Please update version number (if necessary) and add a changelog entry. |
dcharkes
reviewed
Sep 6, 2023
pkgs/native_toolchain_c/CHANGELOG.md
Outdated
| @@ -3,6 +3,8 @@ | |||
| - Added `defines` for specifying custom defines. | |||
| - Added `buildModeDefine` to toggle define for current build mode. | |||
| - Added `ndebugDefine` to toggle define of `NDEBUG` for non-debug builds. | |||
| - Generate position independent code for libraries by default and add | |||
There was a problem hiding this comment.
Auto-publishing expects us to publish the first commit with a non -wip suffix. So this has to go in 0.2.2.
There was a problem hiding this comment.
Ah, sorry, when I looked this morning 0.2.1 was not published yet.
blaugold
commented
Sep 6, 2023
dcharkes
reviewed
Sep 6, 2023
| /// } | ||
| /// } | ||
| /// ``` | ||
| String testSuffix(List<Object> tags) => switch (tags) { |
|
Thanks @blaugold! 🥇 |
|
cc @devoncarew I think we used to get code-coverage and publisher comments on PRs, but they are not on this PR. Did we change some settings? (The publish comment that has a clickable draft-release link is quite handy!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust
cccrate provides defaults for passing-fPICto the compiler that simplify configuration for most use cases. This PR adapts this behavior forCBuilder.Closes #119