Skip to content

Add includes, flags, std, language, cppLinkStdLib options #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 14, 2023

Conversation

blaugold
Copy link
Contributor

@blaugold blaugold commented Sep 8, 2023

This PR adds a few more options to CBuilder that are commonly useful.
The flags option allows users to accomplish most things, even if CBuilder does support the specific use case.

The added options follow the example set by the cc crate.

@blaugold blaugold marked this pull request as ready for review September 8, 2023 16:56
Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w comments

Thanks @blaugold ! 🔧 🚀

@blaugold blaugold changed the title Add includes, flags, std, cpp, cppLinkStdLib options Add includes, flags, std, language, cppLinkStdLib options Sep 11, 2023
@coveralls
Copy link

Coverage Status

coverage: 98.099% (-0.09%) from 98.184% when pulling 8368aef on blaugold:includes-and-flags into 9f24b64 on dart-lang:main.

@blaugold blaugold requested a review from dcharkes September 12, 2023 08:41
@dcharkes
Copy link
Collaborator

@blaugold looks like not all code is covered by tests https://coveralls.io/builds/62578519 (It doesn't show in the UI which lines unfortunately, but you can run coverage locally with dart pub global run coverage:test_with_coverage and use coverage gutters in VS code)

@dcharkes
Copy link
Collaborator

@blaugold looks like not all code is covered by tests https://coveralls.io/builds/62578519 (It doesn't show in the UI which lines unfortunately, but you can run coverage locally with dart pub global run coverage:test_with_coverage and use coverage gutters in VS code)

class Language {
  // ...

  @override
  String toString() => name; // not covered

@blaugold blaugold requested a review from dcharkes September 14, 2023 10:00
Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@auto-submit
Copy link

auto-submit bot commented Sep 14, 2023

auto label is removed for dart-lang/native/125, due to This PR has not met approval requirements for merging. You are not a member of dart-team and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit label Sep 14, 2023
@dcharkes dcharkes merged commit 7faf62c into dart-lang:main Sep 14, 2023
@dcharkes
Copy link
Collaborator

Thanks @blaugold ! 😄

@blaugold blaugold deleted the includes-and-flags branch September 14, 2023 11:55
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
Closed #124.
Closed #125.

* Added `JPrimitive` and its subclasses instead of using the typedefs from `ffi` directly.
* Renamed `JniObject`, `JniString`, and ... to the shorter `JObject`, JString`, and ...
* Made tests more robust by deleting the objects in an arena.
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
Closed #124.
Closed #125.

* Added `JPrimitive` and its subclasses instead of using the typedefs from `ffi` directly.
* Renamed `JniObject`, `JniString`, and ... to the shorter `JObject`, JString`, and ...
* Made tests more robust by deleting the objects in an arena.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants