-
Notifications
You must be signed in to change notification settings - Fork 68
Add includes
, flags
, std
, language
, cppLinkStdLib
options
#125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8aa373f
to
44ca9b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w comments
Thanks @blaugold ! 🔧 🚀
includes
, flags
, std
, cpp
, cppLinkStdLib
optionsincludes
, flags
, std
, language
, cppLinkStdLib
options
@blaugold looks like not all code is covered by tests https://coveralls.io/builds/62578519 (It doesn't show in the UI which lines unfortunately, but you can run coverage locally with |
@blaugold looks like not all code is covered by tests https://coveralls.io/builds/62578519 (It doesn't show in the UI which lines unfortunately, but you can run coverage locally with class Language {
// ...
@override
String toString() => name; // not covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
auto label is removed for dart-lang/native/125, due to This PR has not met approval requirements for merging. You are not a member of dart-team and need 1 more review(s) in order to merge this PR.
|
Thanks @blaugold ! 😄 |
This PR adds a few more options to
CBuilder
that are commonly useful.The
flags
option allows users to accomplish most things, even ifCBuilder
does support the specific use case.The added options follow the example set by the
cc
crate.