Skip to content

[native_assets_builder] Take packageLayout for build and dryRun #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Sep 12, 2023

Enable using PackageLayout in build and run from NativeAssetsBuildRunner, so that does not require reading and reparsing the package config file.

Follow up of:

That PR only covered the code paths in flutter_tools using PackageLayout.packagesWithNativeAssets, this also should cover the paths doing the actual builds.

(Note that flutter_tools requires published dependencies, hence we just land small PRs here and publish right away.)

Context:

@coveralls
Copy link

coveralls commented Sep 12, 2023

Coverage Status

coverage: 98.189%. remained the same when pulling ff89580 on package-layout-2 into a7cd31e on main.

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:native_assets_builder 0.2.2 ready to publish native_assets_builder-v0.2.2
package:native_assets_cli 0.2.0 already published at pub.dev
package:native_toolchain_c 0.2.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@dcharkes dcharkes merged commit 7f30f4b into main Sep 12, 2023
@dcharkes dcharkes deleted the package-layout-2 branch September 12, 2023 11:41
@dcharkes
Copy link
Collaborator Author

Thanks @HosseinYousefi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants