Skip to content

[native_toolchain_c] Enable relocations in RO sections on clang #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

dcharkes
Copy link
Collaborator

Closes: #130

Revving pubspec version isn't necessary, this is mostly to enable to roll to the Dart SDK. (Users can get this after a next version is merged.)

@coveralls
Copy link

Coverage Status

coverage: 98.195% (+0.002%) from 98.193% when pulling 8b5ceeb on z-notext into 5177659 on main.

@dcharkes dcharkes changed the title [native_toolchain_c] Enable relocations in RO secionts [native_toolchain_c] Enable relocations in RO sections Sep 14, 2023
@dcharkes dcharkes changed the title [native_toolchain_c] Enable relocations in RO sections [native_toolchain_c] Enable relocations in RO sections on clang Sep 14, 2023
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@dcharkes dcharkes merged commit bbcbc1f into main Sep 14, 2023
@dcharkes dcharkes deleted the z-notext branch September 14, 2023 08:57
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
Closes #132.

ASM backend, parses classes, fields and method signatures from the metadata to add generic type information to other-wise type-erased generics.
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
Closes #132.

ASM backend, parses classes, fields and method signatures from the metadata to add generic type information to other-wise type-erased generics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test failures rolling into the sdk repo due to recent commits
3 participants