[CI] Clang 17 (from Dart SDK) CI coverage #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type-infra
athomas
reviewed
Sep 15, 2023
HosseinYousefi
approved these changes
Sep 15, 2023
devoncarew
reviewed
Sep 15, 2023
| @@ -0,0 +1,58 @@ | |||
| name: dart | |||
There was a problem hiding this comment.
"SDK smoke test"? We already have one workflow in this repo names 'dart'.
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get some kind of coverage for the clang we use in the Dart SDK to prevent errors when rolling.
I've made it a separate CI job for now.
We could consider adding it to the central matrix, but we should probably consider splitting up the central matrix according to #70 (comment) now that we have published versions of packages.
Maybe we should consider also being able to somehow skip tests for cross compilation and Android, so we don't have to re-run these on this job and can avoid installing those deps.
I'm intending to land this while red, so that it's easier to test a fix for the redness afterwards.
Thanks @athomas for the help!
FYI @devoncarew.