-
Notifications
You must be signed in to change notification settings - Fork 69
[native_assets_*] Validator #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds validation to the hook outputs in two places:
build
andlink
methods used in hook implementations.native_assets_builder
after invoking the hook.In the native assets builder we also validate that assets for linking are routed to packages that have link hooks.
Also, fixes some bugs, some tests, and examples that were violating the invariants.
Closes: #1409
Closes: #1411