Skip to content

[native_assets_builder] Fail early on too old native_assets_cli #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

dcharkes
Copy link
Collaborator

Since we know the PackageConfig, we can check in the native assets builder what version of native_assets_cli is used in the hook implementations.

Since we know the PackageConfig, we also know the package root of native_assets_cli and try to find the version of the protocol it's using.

If we find that the protocol version is no longer supported, give an error message early and stop building native assets instead of actually invoking the hook.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Base automatically changed from nab-pub-workspaces-take-2 to main January 22, 2025 10:29
@dcharkes dcharkes force-pushed the check-protocol-version branch from 1a2ddda to dd3c0bc Compare January 22, 2025 10:31
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jan 22, 2025
@dcharkes dcharkes marked this pull request as ready for review January 22, 2025 10:36
@coveralls
Copy link

Coverage Status

coverage: 83.885% (+0.008%) from 83.877%
when pulling eff23b8 on check-protocol-version
into 4282a79 on main.

@dcharkes dcharkes merged commit 999ddf1 into main Jan 22, 2025
40 checks passed
@dcharkes dcharkes deleted the check-protocol-version branch January 22, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit package:hooks_runner package:hooks type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants