[native_assets_builder] Refactor API to ProtocolExtensions
#2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
mosuem
approved these changes
Mar 11, 2025
| import '../../code_assets_builder.dart'; | ||
| import 'validation.dart'; | ||
|
|
||
| final class CodeAssetExtension implements ProtocolExtension { |
| import '../../data_assets_builder.dart'; | ||
| import 'validation.dart'; | ||
|
|
||
| final class DataAssetsExtension implements ProtocolExtension { |
| required BuildValidator buildValidator, | ||
| required ApplicationAssetValidator applicationAssetValidator, | ||
| required List<String> buildAssetTypes, | ||
| required List<ProtocolExtension> extensions, |
There was a problem hiding this comment.
Add docs about the extensions parameter - why do we need to pass it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a concept of protocol extensions, which package together everything belonging to a protocol extension.
Closes: #2088
As a bonus, this better abstraction reduces LOC.
The
validationmethods are now all internal to the extensions. Thesetupmethods stay exported because they are used extensively in hook-helper-packages (e.g.native_toolchain_c).