Skip to content

[native_assets_cli] Make generated syntax files stand on their own #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

dcharkes
Copy link
Collaborator

Bug: #1826

package:json_syntax_generator is only reusable if the files are self contained.

Alternatively, we could make the generator take a config option for a JSON import. However, the downside would be that we would need copy paste the library file to multiple places.

Additionally, this PR cleans up all other uses of the utils/json.dart in package:native_assets_cli. The only remaining JSON helper is sortOnKey() because the asset-extension touches JSON manually and needs to sort the keys. (This could be addressed when addressing #2090.)

@dcharkes dcharkes requested a review from HosseinYousefi March 17, 2025 15:30
@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:hooks labels Mar 17, 2025
@dcharkes dcharkes changed the base branch from main to refactor-generator March 17, 2025 15:30
@dcharkes dcharkes requested a review from mosuem March 17, 2025 15:30
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the refactor-generator branch from 69fc94b to 4694895 Compare March 17, 2025 18:58
@dcharkes dcharkes force-pushed the refactor-generator-2 branch from aff532f to fe88a10 Compare March 17, 2025 19:00
@github-actions github-actions bot removed the type-infra A repository infrastructure change or enhancement label Mar 17, 2025
Base automatically changed from refactor-generator to main March 17, 2025 19:11
@dcharkes dcharkes force-pushed the refactor-generator-2 branch from fe88a10 to b7d0007 Compare March 17, 2025 20:19
@auto-submit auto-submit bot merged commit 329b975 into main Mar 17, 2025
40 checks passed
@auto-submit auto-submit bot deleted the refactor-generator-2 branch March 17, 2025 20:29
@coveralls
Copy link

Coverage Status

coverage: 86.587% (-0.04%) from 86.63%
when pulling b7d0007 on refactor-generator-2
into a3aad77 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants