Skip to content

[native_assets_cli] Use JSON enums where applicable #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Mar 24, 2025

Enums in JSON schemas are more concise and more apt than a list of consts.

Thanks @jonasfj for the tip!

(Also updates the schema analyzer to recognize them.)

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the link-mode-preference-json branch from d44e0c3 to eb0b868 Compare March 26, 2025 06:47
Base automatically changed from link-mode-preference-json to main March 26, 2025 06:58
@dcharkes dcharkes force-pushed the json-schema-enums branch from 0ae413d to 4730075 Compare March 26, 2025 07:00
@auto-submit auto-submit bot merged commit b272930 into main Mar 26, 2025
35 checks passed
@auto-submit auto-submit bot deleted the json-schema-enums branch March 26, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants