[native_assets_cli] Prevent EncodedAsset
and Metadata
hashcode changing
#2131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2045
We have two types of classes in the semantic API:
These classes are mirrored by a builder class.
Objects from these classes cannot be passed from input to output in hooks.
These classes do not override
hashCode
andoperator ==
.Examples:
CodeConfig
,BuildInput
.These classes have a public constructor with it's constituent fields.
Objects from these classes may be passed from input to output in hooks.
These classes do override
hashCode
andoperator ==
.Examples:
CodeAsset
,Architecture
,OS
,DataAsset
.This changes
Metadata
andEncodedAsset
to follow pattern 2 fully:This means the
hashCode
andoperator ==
are now correct.We could consider changing
Metadata
andEncodedAsset
to pattern 1, but I didn't want to refactor that code in this PR. For more details:EncodedAsset
is not immutable but overrideshashCode
#2045