Skip to content

[native_assets_builder] user-defines in workspace pubspec #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

dcharkes
Copy link
Collaborator

Changes the test-data to have user-defines in the workspace pubspec, such that dart test etc. work on that project.

Keep the (ineffective) user-defines in the project pubspec, because the integration tests copy that pubspec and remove the resolution: workspace entry.

Copy link

github-actions bot commented Apr 11, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_builder Breaking 0.14.0 0.15.0-0 0.15.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Apr 11, 2025

Coverage Status

coverage: 77.013%. remained the same
when pulling f1a2abe on user-defines-pub-workspace
into 0bda93b on main.

@auto-submit auto-submit bot merged commit 0d57838 into main Apr 11, 2025
31 checks passed
@auto-submit auto-submit bot deleted the user-defines-pub-workspace branch April 11, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants