-
Notifications
You must be signed in to change notification settings - Fork 68
Merge jnigen #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge jnigen #545
Conversation
Stub from `flutter create --template plugin_ffi` with GitHub workflow support.
…port. (dart-archive/jnigen#87) * C bindings no longer use fully qualified names. Instead, it uses number-renamed simple names. The classes are sorted in the summarizer to ensure the order is deterministic. This enables shorter symbol names and less verbose bindings. * C bindings are formatted using same style as Dart SDK, using clang-format. If clang-format is not available, jnigen will issue a warning. Closes: https://github.com/dart-lang/jnigen/issues/84 * C bindings return `JniResult`. The older `Jni.checkException` stopgap is removed. It reduces one line per function binding in dart. Lastly exceptions will work properly on android Closes: https://github.com/dart-lang/jnigen/issues/56
…en#404) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…hive/jnigen#411) Bumps [subosito/flutter-action](https://github.com/subosito/flutter-action) from 2.10.0 to 2.12.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/subosito/flutter-action/releases">subosito/flutter-action's releases</a>.</em></p> <blockquote> <h2>v2.12.0</h2> <p>No release notes provided.</p> <h2>v2.11.0</h2> <p>Allow git ref as version for master channel:</p> <pre lang="yaml"><code>steps: - uses: actions/checkout@v3 - uses: subosito/flutter-action@v2 with: flutter-version: '5b12b74' # tag, commit or branch channel: 'master' - run: flutter --version </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/subosito/flutter-action/commit/2783a3f08e1baf891508463f8c6653c258246225"><code>2783a3f</code></a> ensure setup.sh executable; fixes <a href="https://redirect.github.com/subosito/flutter-action/issues/245">https://github.com/dart-lang/jnigen/issues/245</a></li> <li><a href="https://github.com/subosito/flutter-action/commit/c33c37022b3aac486cc5e7aea5c7f6b8b0f421e1"><code>c33c370</code></a> Extract to a temporary location to enable moving of flutter folder. (<a href="https://redirect.github.com/subosito/flutter-action/issues/227">https://github.com/dart-lang/jnigen/issues/227</a>)</li> <li><a href="https://github.com/subosito/flutter-action/commit/cc97e1648fff6ca5cc647fa67f47e70f7895510b"><code>cc97e16</code></a> feat: Allow git ref as version in <code>master</code> channel (<a href="https://redirect.github.com/subosito/flutter-action/issues/237">https://github.com/dart-lang/jnigen/issues/237</a>)</li> <li><a href="https://github.com/subosito/flutter-action/commit/ed388baf1d5404fd6ef3c54c2f82e6159150b60f"><code>ed388ba</code></a> fixes <a href="https://redirect.github.com/subosito/flutter-action/issues/224">https://github.com/dart-lang/jnigen/issues/224</a>; update readme</li> <li>See full diff in <a href="https://github.com/subosito/flutter-action/compare/48cafc24713cca54bbe03cdc3a423187d413aafa...2783a3f08e1baf891508463f8c6653c258246225">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…en#412) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@8ade135...b4ffde6) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
60ccc02
to
6952d25
Compare
Can we review and land some of the steps on the JNIgen repo before doing the history rewrite? It's a bit hard to review changes before hitting the merge button. Candidates:
|
6952d25
to
954c1f7
Compare
I basically rewrote the history in a way that the top-level readme has always been in
Again, I rewrote the history so that the name of the workflow's file is There is a separate commit with only the new changes (Make GitHub workflow ready for the merger) I'll try to get the CI working, and if that happens then I think we're in a good spot to merge it. |
954c1f7
to
5741f2c
Compare
5741f2c
to
9d35138
Compare
Caution
Do NOT squash merge!
Followed the instructions from dart-lang/tools#100.
Closes #555.
History change commands:
pkgs/
AUTHORS
andLICENSE
files as they already exist..github
related files to their correct path and remove existing files.Content of
textreplacement
:[jnigen]
to the beginning of every commit message and change the issue/PR numbers to the correct link in thejnigen
repo.Content of
msgreplacement
: