Skip to content

Index and search public API symbols. #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2018
Merged

Index and search public API symbols. #1220

merged 1 commit into from
Apr 25, 2018
+300 −16

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Apr 19, 2018

#1179

  • Deployed in staging.
  • It increased the memory requirement by ~60%, in staging: from 620MB -> 980MB.
  • It has a structure to later support direct API links in the results.

@isoos isoos requested a review from jakobr-google April 19, 2018 17:18
@isoos isoos mentioned this pull request Apr 19, 2018
Closed
jakobr-google
jakobr-google approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/lib/search/backend.dart Outdated
final results = pathMap.keys.map((key) {
final path = pathMap[key];
final symbols = symbolMap[key].toList()..sort();
print('$path: $symbols');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover debugging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah :/

@isoos isoos merged commit 78bd186 into dart-lang:master Apr 25, 2018
@isoos isoos deleted the search_index2 branch April 25, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobr-google jakobr-google

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isoos @jakobr-google @googlebot