Proposal: ScoreCard model #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sortie
approved these changes
Jun 28, 2018
app/lib/scorecard/models.dart
Outdated
| List<String> panaPlatformTags; | ||
|
|
||
| @db.DoubleProperty() | ||
| double documentationScore; |
There was a problem hiding this comment.
Document the fields in this key data class? For instance, is the values in documentationScore between 0.0 and 1.0, or 0.0 and 100.0?
app/lib/scorecard/models.dart
Outdated
|
|
||
| void updateOverallScore() { | ||
| // TODO: use documentationScore too | ||
| overallScore = calculateOverallScore( |
There was a problem hiding this comment.
Suggestion: Can overallScore be a getter that dynamically returns the score? Or can healthScore, maintenanceScore, popularityScore, and documentationScore be setters that also automatically regenerates the score?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step for #1352:
ScoreCardwould be the new all-unifying Datastore entity that holds PackageVersion score and other details (the currentAnalysisExtract), whileScoreCardReportwould be the new place for detailed reports for:pana(the currentAnalysisView),dartdoc(coverage report and score), and possible further ones like runtime analysis.I've opted to not having a two-level structure (like
PackageandPackageVersion), rather having a single entry for a given combination of that.A long-term aspect: this should make the items in
lib/analysis/models.dartobsolete.