Skip to content

Lexicographically sortable runtimeVersion. #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Lexicographically sortable runtimeVersion. #1497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/shared/versions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'package:pub_semver/pub_semver.dart';
import 'utils.dart' show isNewer;

// update this whenever one of the other versions change
final String runtimeVersion = '2018.7.28';
final String runtimeVersion = '2018.08.02';
final Version semanticRuntimeVersion = new Version.parse(runtimeVersion);

// keep in-sync with SDK version in .travis.yml, .mono_repo.yml and Dockerfile
Expand Down
8 changes: 7 additions & 1 deletion app/test/shared/versions_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@ void main() {
dartdocVersion,
customizationVersion,
].join('//').hashCode;
expect(hash, 1051343778);
expect(hash, 425687417);
});

test('runtime version should be (somewhat) lexicographically ordered', () {
expect(runtimeVersion.length, greaterThanOrEqualTo(10));
expect(new RegExp(r'\d{4}\.\d{2}\.\d{2}.*').matchAsPrefix(runtimeVersion),
isNotNull);
});

test('runtime sdk version should match travis and dockerfile', () async {
Expand Down