Skip to content

Fix ScoreCard update and save pana report. #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2018
Merged

Fix ScoreCard update and save pana report. #1597

merged 2 commits into from
Sep 12, 2018
+83 −29

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Sep 11, 2018

#1352

  • Storing pana report in the ScoreCardReport.
  • Fixed bugs that prevented storing ScoreCard properly.

@isoos isoos requested a review from sortie September 11, 2018 17:34
sortie
sortie approved these changes Sep 12, 2018
View reviewed changes
Copy link

@sortie sortie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app/lib/scorecard/models.dart Outdated

/// The report types that are already done for the ScoreCard.
@CompatibleStringListProperty()
List<String> reportTypes;
List<String> reportTypes = <String>[];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention it contains ReportType constants?

@isoos isoos merged commit c9aa840 into dart-lang:master Sep 12, 2018
@isoos isoos deleted the scorecard_pana branch September 12, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sortie sortie

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isoos @sortie @googlebot