Upgrade dartdoc to 0.21.1 #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sortie
approved these changes
Sep 26, 2018
| @@ -4,7 +4,7 @@ | |||
| <meta charset="utf-8"> | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <meta name="generator" content="made with love by dartdoc 0.20.4"> | |||
| <meta name="generator" content="made with love by dartdoc 0.21.1"> | |||
There was a problem hiding this comment.
Can we mock out the dartdoc version so updating it doesn't change this file unless the output format actually changed?
There was a problem hiding this comment.
I'd rather keep it here, because updating the customization may not be at the same time with the update of the dartdoc version.
| @@ -87,12 +87,12 @@ <h3 id="usage">Usage</h3> | |||
| <h2>Libraries</h2> | |||
| <dl> | |||
| <dt id="models"> | |||
| <span class="name"><a href="models/models-library.html">models</a></span> | |||
| <span class="name"><a href="models/models-library.html">models</a></span> | |||
There was a problem hiding this comment.
Should the trailing whitespace be reported as a bug in dartdoc?
There was a problem hiding this comment.
Reported: dart-lang/dartdoc#1762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1645
From our perspective the generated dartdoc didn't change much.