Skip to content

Reject uploads on case insensitive filename matches. #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Reject uploads on case insensitive filename matches. #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions app/lib/frontend/backend.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,19 @@ Future<_ValidatedUpload> _parseAndValidateUpload(

final files = await listTarball(filename);

// Check whether the files can be extracted on case-preserving file systems
// (e.g. on Windows). We can't allow two files with the same case-insensitive
// name.
final lowerCaseFiles = <String>{};
for (String file in files) {
final lower = file.toLowerCase();
if (lowerCaseFiles.contains(lower)) {
throw GenericProcessingException(
'Filename collision on case-preserving file systems: $file.');
}
lowerCaseFiles.add(lower);
}

// Searches in [files] for a file name [name] and compare in a
// case-insensitive manner.
//
Expand Down
3 changes: 1 addition & 2 deletions app/lib/shared/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ Future<T> withTempDirectory<T>(Future<T> func(Directory dir),
}

Future<List<String>> listTarball(String path) async {
// List files up-to 4 directory levels:
final args = ['--exclude=*/*/*/*/*', '-tzf', path];
final args = ['-tzf', path];
final result = await Process.run('tar', args);
if (result.exitCode != 0) {
_logger.warning('The "tar $args" command failed:\n'
Expand Down