Skip to content

Render-blocking dark-theme initialization for dartdoc pages. #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jun 27, 2025

@isoos
Copy link
Collaborator Author

isoos commented Jul 1, 2025

I have checked again with both Firefox and Chrome, with various different settings (including the <script blocking="render" ... attribute). The current init script improves the flashing on both browsers, and e.g. the blocking attribute doesn't add much on top of it. However, the site is not completely flash-free, in certain cases I've noticed a few more full or partial flashing, opening tracking issues for them (#8841 and #8842).

@isoos isoos merged commit 5004edb into dart-lang:master Jul 1, 2025
59 of 60 checks passed
@isoos isoos deleted the dartdoc-init branch July 1, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants