Skip to content

Pub lish should run [dart|flutter] analyze #3391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakemac53 opened this issue Apr 14, 2022 · 1 comment · Fixed by #3568
Closed

Pub lish should run [dart|flutter] analyze #3391

jakemac53 opened this issue Apr 14, 2022 · 1 comment · Fixed by #3568
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@jakemac53
Copy link
Contributor

It would be a nice extra sanity check if pub lish ran analysis on the project, and gave a warning if there were any diagnostics.

This would have caught a mistake I made today, where I published a version of test_core (after removing dependency overrides on the local version of test_api). I thought there were no changes in test_api that test_core depended on, and so I hadn't published a new version of that, but when I removed the override it did in fact cause some analysis errors. I didn't notice it in time, and pub didn't alert me, so I had to retract the version. Super glad I can retract versions now though!

@sigurdm
Copy link
Contributor

sigurdm commented May 5, 2022

I think this is a good idea. Surprised we don't already do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants