-
Notifications
You must be signed in to change notification settings - Fork 232
Need tests for code that determines what files are published with a package #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
|
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Removed Type-Defect label. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Removed this from the M3 milestone. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 We should test this as part of our "pub lish" integration tests, but right now we have no way of parsing a multipart/form-data request. Marked this as being blocked by dart-lang/sdk#2488. |
<img src="https://avatars.githubusercontent.com/u/1343914?v=3" align="left" width="48" height="48"hspace="10"> Comment by sgjesse Marked this as being blocked by dart-lang/sdk#8834. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Removed this from the M4 milestone. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 Fixed by dart-lang/sdk@f878dcc. Added Fixed label. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="96" height="96"hspace="10"> Issue by munificent
Originally opened as dart-lang/sdk#7391
The code for getting the list of files to include in a package has a bunch of interesting corners related to symlinks, git, etc. We've seen a few issues there where it doesn't give us the files we expect, and we don't have good test coverage for it. We should. In particular:
The text was updated successfully, but these errors were encountered: