Skip to content

Need tests for code that determines what files are published with a package #377

Closed
@DartBot

Description

@DartBot

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="96" height="96"hspace="10"> Issue by munificent
Originally opened as dart-lang/sdk#7391


The code for getting the list of files to include in a package has a bunch of interesting corners related to symlinks, git, etc. We've seen a few issues there where it doesn't give us the files we expect, and we don't have good test coverage for it. We should. In particular:

  1. Make sure packages directories are excluded.
  2. Make sure symlinks are handled correctly.
  3. Make sure .gitignored files are ignored.
  4. Make sure .gitignored directories (and their contents) are ignored.
  5. Make sure "." files are ignored in non-git packages.

Activity

DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


  1. Make sure "pubspec.lock" is always omitted.
DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed Type-Defect label.
Added Type-Enhancement label.

DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed this from the M3 milestone.
Added this to the M4 milestone.

DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


We should test this as part of our "pub lish" integration tests, but right now we have no way of parsing a multipart/form-data request.


Marked this as being blocked by dart-lang/sdk#2488.

DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/1343914?v=3" align="left" width="48" height="48"hspace="10"> Comment by sgjesse


Marked this as being blocked by dart-lang/sdk#8834.
Unmarked this as being blocked by dart-lang/sdk#2488.

DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed this from the M4 milestone.
Added this to the M5 milestone.

DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Set owner to @nex3.
Added Started label.

DartBot

DartBot commented on Jun 5, 2015

@DartBot
Author

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Fixed by dart-lang/sdk@f878dcc.


Added Fixed label.

added a commit that references this issue on Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type-enhancementA request for a change that isn't a bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @nex3@DartBot

      Issue actions

        Need tests for code that determines what files are published with a package · Issue #377 · dart-lang/pub