Closed
Description
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="96" height="96"hspace="10"> Issue by munificent
Originally opened as dart-lang/sdk#7391
The code for getting the list of files to include in a package has a bunch of interesting corners related to symlinks, git, etc. We've seen a few issues there where it doesn't give us the files we expect, and we don't have good test coverage for it. We should. In particular:
- Make sure packages directories are excluded.
- Make sure symlinks are handled correctly.
- Make sure .gitignored files are ignored.
- Make sure .gitignored directories (and their contents) are ignored.
- Make sure "." files are ignored in non-git packages.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
Removed Type-Defect label.
Added Type-Enhancement label.
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
Removed this from the M3 milestone.
Added this to the M4 milestone.
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3
We should test this as part of our "pub lish" integration tests, but right now we have no way of parsing a multipart/form-data request.
Marked this as being blocked by dart-lang/sdk#2488.
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/1343914?v=3" align="left" width="48" height="48"hspace="10"> Comment by sgjesse
Marked this as being blocked by dart-lang/sdk#8834.
Unmarked this as being blocked by dart-lang/sdk#2488.
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
Removed this from the M4 milestone.
Added this to the M5 milestone.
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3
Set owner to @nex3.
Added Started label.
DartBot commentedon Jun 5, 2015
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3
Fixed by dart-lang/sdk@f878dcc.
Added Fixed label.
Prepare new release: 0.11.8 (dart-lang#377)