-
Notifications
You must be signed in to change notification settings - Fork 231
If a git path in a pubspec is relative interpret it relative to the pubspec #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Added Community-StarterBug label. |
<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl Removed this from the Later milestone. |
<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl Removed Oldschool-Milestone-Later label. |
<img src="https://avatars.githubusercontent.com/u/2130849?v=3" align="left" width="48" height="48"hspace="10"> Comment by kaendfinger Shouldn't this have a PatchesWelcome label? |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Patches are welcome on every bug! :) I think the "PatchesWelcome" usually means "we don't intend to put time into this ourselves, but will take a contribution from someone else for it", but I'm not positive since I haven't used that tag. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
Well, let me qualify that by saying contributions are welcome on every bug, but we do like to know a bit about what the contributor has in mind before seeing an actual patch. We don't always do a great job of writing down the full context behind some bug, so there may be some tribal knowledge to impart before a contributor gets coding. |
This is totally different than #1305. This is requesting that the Git URL itself be interpreted relative to the pubspec's location. |
Oops! |
I'm not sure if this issue is the same as #2447? |
We've run into this problem when trying to share packages via Git. In a shared package repo we would like to do the following directory structure:
With the following dependencies:
core_package:
path: ../core_package And dependencies:
core_package:
path: ../core_package Being referenced in dependencies:
core_package:
git:
url: https://github.com/org/shared-repo.git
ref: main
path: packages/core_package
web_impl_package:
git:
url: https://github.com/org/shared-repo.git
ref: main
path: packages/web_impl_package However we end up with the error:
It would be great if multiple dependencies pointing to the same Git |
cc @sigurdm |
maybe I tried to tackle something similar @danielvestergaard
This
Then again inside the
While in the
I got so far that all static code analysis is successful, however even after successful XCode build I get
I wonder what I confused here ? |
@sigurdm can you provide an update on this work? |
Yeah - I have a PR with the functionality ready - but It is taking a few shortcuts, I need to sit down and find a cleaner way to do this. I hope to get around to do that soon... |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="96" height="96"hspace="10"> Issue by munificent
Originally opened as dart-lang/sdk#8570
You can use a file path as a git dependency. When you do, it's interpreted as relative to the package directory of the root package. It should be resolve as relative to the pubspec that contains the dependency (like relative path deps are).
The text was updated successfully, but these errors were encountered: