Skip to content

Set the content type during publish to application/gzip #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2017
Merged

Set the content type during publish to application/gzip #1671

merged 1 commit into from
Jul 19, 2017

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jul 19, 2017

@kevmoo kevmoo requested a review from natebosch July 19, 2017 14:32
natebosch
natebosch approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

@kevmoo
Copy link
Member Author

kevmoo commented Jul 19, 2017 via email

@kevmoo kevmoo merged commit 3e4890f into master Jul 19, 2017
@kevmoo kevmoo deleted the i230_content_type_publish branch July 19, 2017 19:30
kevmoo added a commit that referenced this pull request Jul 19, 2017
@kevmoo
Revert "Set the content type during publish to application/gzip (#1671)"
7a0d955 
This reverts commit 3e4890f.

Does not fix #1666
Tracking internally here http://b/63855519
kevmoo added a commit that referenced this pull request Jul 19, 2017
@kevmoo
Revert "Set the content type during publish to application/gzip (#1671)…
5f6cda0 
…" (#1672)

This reverts commit 3e4890f.

Does not fix #1666
Tracking internally here http://b/63855519
nex3
nex3 reviewed Sep 19, 2017
View reviewed changes
lib/src/command/lish.dart
@@ -5,6 +5,7 @@
import 'dart:async';

import 'package:http/http.dart' as http;
import 'package:http_parser/http_parser.dart' as http_parser;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not typically imported with a prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 left review comments

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevmoo @nex3 @natebosch @googlebot