Refactor some solver stuff #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it statically clearer which type of assignment is happening where.
Before, we considered an assignment to be a decision if it was positive and the package name was a PackageId.
This gives us a central place to track which decisions have been made, rather than needing to derive that information from the assignment list.
Now that we're tracking decisions in PartialSolution, we no longer need to distinguish decision-like terms from derivation-like terms.
munificent
approved these changes
Mar 20, 2018
lib/src/package_name.dart
Outdated
| !constraint.isAny || (source is! PathSource && source is! GitSource)) { | ||
| !isRoot && | ||
| (!constraint.isAny || | ||
| (source is! PathSource && source is! GitSource))) { |
There was a problem hiding this comment.
Operators nested four deep is pretty rough. Maybe break some of this out into local variables so it's clearer what they represent?
Or perhaps add a getter on Source that means what (source is! PathSource && source is! GitSource) means? Is it "has multiple versions"?
There was a problem hiding this comment.
We do have Source.hasMultipleVersions, but I don't think it's exactly the right fit here—we usually expect users to include version constraints for SDK dependencies, even though they technically only have one version available at a time.
I've factored this out into a getter to reduce nesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.