Triage more solver tests #1842
Merged
Triage more solver tests #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test's behavior was never actually stable; which path takes precedence is entirely dependent on the details of the solver, such as which packages sorts alphabetically first. Since it's so implementation-sensitive, it doesn't make much sense to crystallize in a test.
munificent
requested changes
Mar 21, 2018
| @@ -73,38 +71,4 @@ main() { | |||
| await d.appPackagesFile( | |||
| {"foo": "../foo", "bar": "../bar", "shared": "../shared"}).validate(); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
What happened to these tests?
There was a problem hiding this comment.
I explained in the commit message.
munificent
approved these changes
Mar 22, 2018
munificent
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.