Reland "Add flag controlling creation of .packages file."
#3413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art-lang#2757)" (dart-lang#3357)" This reverts commit d1c0e3f.
mit-mit
approved these changes
May 4, 2022
jonasfj
approved these changes
May 5, 2022
|
@sigurdm is this ready to go? |
|
Yes - I just wanted it to be rolled into the sdk in its own CL and got distracted... Will land this Thursday |
2 tasks
sigurdm
added a commit
to flutter/flutter
that referenced
this pull request
Jun 21, 2024
Not sure exactly what this was supposed to do, but pub no longer writes ".packages" and has not done since: dart-lang/pub#3413. So this check would never find a '.packages'. Not sure if this code was doing anything useful - but it does not seem to have been missed for a couple of years. This is a warm-up for: #150196 It was added in #6093 seemingly without tests of this functionality.
sigurdm
added a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
Not sure exactly what this was supposed to do, but pub no longer writes ".packages" and has not done since: dart-lang/pub#3413. So this check would never find a '.packages'. Not sure if this code was doing anything useful - but it does not seem to have been missed for a couple of years. This is a warm-up for: flutter#150196 It was added in flutter#6093 seemingly without tests of this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of #3357 that itself reverted: #2757
This should be safe now that flutter/flutter#99677 has landed.
Fixes dart-lang/sdk#47431