Skip to content

Checksum validation of archives (#2281) #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 3, 2022
Merged

Checksum validation of archives (#2281) #3546

merged 28 commits into from
Oct 3, 2022

Conversation

nehalvpatel
Copy link
Contributor

@nehalvpatel nehalvpatel commented Sep 1, 2022 •
edited by sigurdm
Loading

Fixes: #2281

nehalvpatel
nehalvpatel commented Sep 1, 2022
View reviewed changes
jonasfj
jonasfj reviewed Sep 2, 2022
View reviewed changes
jonasfj
jonasfj reviewed Sep 2, 2022
View reviewed changes
jonasfj
jonasfj reviewed Sep 2, 2022
View reviewed changes
sigurdm
sigurdm reviewed Sep 6, 2022
View reviewed changes
sigurdm
sigurdm reviewed Sep 6, 2022
View reviewed changes
sigurdm
sigurdm reviewed Sep 6, 2022
View reviewed changes
sigurdm
sigurdm reviewed Sep 6, 2022
View reviewed changes
sigurdm
sigurdm reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs some testing.

I think you can set the test package-server up so that it returns a checksum, and then make a test that the client validates, and somehow also check that the request is retried.

@nehalvpatel nehalvpatel changed the title GCS checksum validation (#2281) Checksum validation of archives (#2281) Sep 16, 2022
sigurdm
sigurdm reviewed Sep 19, 2022
View reviewed changes
sigurdm
sigurdm reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

jonasfj
jonasfj reviewed Sep 20, 2022
View reviewed changes
jonasfj
jonasfj reviewed Sep 20, 2022
View reviewed changes
jonasfj
jonasfj reviewed Sep 20, 2022
View reviewed changes
jonasfj
jonasfj reviewed Sep 20, 2022
View reviewed changes
@nehalvpatel nehalvpatel marked this pull request as ready for review September 27, 2022 02:47
sigurdm
sigurdm reviewed Sep 27, 2022
View reviewed changes
sigurdm
sigurdm reviewed Sep 27, 2022
View reviewed changes
@sigurdm
Copy link
Contributor

sigurdm commented Sep 27, 2022

This starts to look good!

@nehalvpatel @sigurdm
Update lib/src/source/hosted.dart
ce3a0ec 
Co-authored-by: Sigurd Meldgaard <[email protected]>
@nehalvpatel nehalvpatel mentioned this pull request Sep 28, 2022
Open
9 tasks
sigurdm
sigurdm reviewed Sep 29, 2022
View reviewed changes
jonasfj
jonasfj approved these changes Sep 29, 2022
View reviewed changes
@nehalvpatel nehalvpatel force-pushed the gcs_checksum_validation branch from 3206063 to 63e5f29 Compare September 30, 2022 16:23
@sigurdm sigurdm merged commit 8dba957 into dart-lang:master Oct 3, 2022
@nehalvpatel nehalvpatel deleted the gcs_checksum_validation branch October 3, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate CRC32c if x-goog-hash header is present
3 participants
@nehalvpatel @sigurdm @jonasfj