Samples for enhanced enums feature

[miquelbeltran]

Hi! 👋

I'm doing some work for @RedBrogdon, and creating samples for some new upcoming Dart features.

In this PR, I have created a series of examples for the upcoming enhanced enums feature dart-lang/sdk#47849

I followed the same pattern as in the extension_methods examples, creating different files showing different functionality.

I also have created a complete example inside the complete_example.dart file.

All examples also contain tests.

[kevmoo]

We shouldn't need this, right?

[RedBrogdon]

The lock file in general, you mean?

[kevmoo]

Right. For teams trying to align their deps it's nice. Otherwise it's a file that just changes randomly and creates a bunch of noise in Git – IMHO

[RedBrogdon]

The docs agree with you:

https://dart.dev/guides/libraries/private-files

As a person who arrived at Dart through Flutter, I'm used to checking in the lock file for pretty much everything, whereas you and Parker (as true Dart coders) are probably used to leaving it out more often than including it.

Looks like you're correct, though, so +1 for yanking it. 😄

[domesticmouse]

That guideline is for libraries, and this, unless my reading is incorrect, isn't a library.

My understanding is we check in pubspec.lock files for executable samples as a way of making it really easy for people to get a working version of the code. dart pub get will pull a tested set of dependencies that we know work together.

Please revert.

[johnpryan]

Right now, the convention in this repo is not to commit the lockfiles.

[miquelbeltran]

Thanks! I will follow the repo convention then and remove the file.

[johnpryan]

Looks good overall, I would consider demonstrating that == and hashCode aren't required and that switch/case can be used with enhanced enums too.

[miquelbeltran]

Thanks for the review @johnpryan I applied all the suggestions

[domesticmouse]

Does this repository not have a CI? My reading of this PR with it's minimum Dart version should fail when Dart stable is run.

[johnpryan]

CI won't run until we do the mono_repo dance, I'm okay with merging into main and creating a beta branch if we don't have one already.