Reland "[cfe,corelib] Add class 'Record' to the core library"

Part of #49713

Change-Id: I56bfca49492d14bb561b32993fd9adfe775b7400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259583
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/_fe_analyzer_shared/test/inheritance/data/object_opt_in/core.dart

@@ -78,3 +78,7 @@ class Type {}
 
 /*class: Invocation:Invocation,Object*/
 class Invocation {}
+
+/*cfe|cfe:builder.class: Record:Object,Record*/
+/*analyzer.class: Record:Record,Object*/
+class Record {}

pkg/_fe_analyzer_shared/test/inheritance/data/object_opt_out/core.dart

@@ -83,3 +83,7 @@ class Type {}
 
 /*class: Invocation:Invocation,Object*/
 class Invocation {}
+
+/*analyzer.class Record:Record,Object*/
+/*cfe|cfe:builder.class: Record:Object,Record*/
+class Record {}

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -17,6 +17,7 @@ import 'package:analyzer/dart/element/type_provider.dart';
 import 'package:analyzer/diagnostic/diagnostic.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/error/listener.dart';
+import 'package:analyzer/src/dart/analysis/experiments.dart';
 import 'package:analyzer/src/dart/ast/ast.dart';
 import 'package:analyzer/src/dart/ast/extensions.dart';
 import 'package:analyzer/src/dart/element/class_hierarchy.dart';
@@ -1025,6 +1026,16 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
   @override
   void visitNamedType(NamedType node) {
     _typeArgumentsVerifier.checkNamedType(node);
+    bool isDartCoreRecordVisible =
+        _currentLibrary.featureSet.isEnabled(Feature.records) ||
+            FeatureSet.latestLanguageVersion().isEnabled(Feature.records);
+    if ((node.type?.isDartCoreRecord ?? false) && !isDartCoreRecordVisible) {
+      errorReporter.reportErrorForToken(
+          ParserErrorCode.EXPERIMENT_NOT_ENABLED, node.beginToken, [
+        Feature.records.enableString,
+        "${Feature.records.releaseVersion ?? ExperimentStatus.currentVersion}"
+      ]);
+    }
     super.visitNamedType(node);
   }
 
@@ -1165,6 +1176,23 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
       _checkForUnqualifiedReferenceToNonLocalStaticMember(node);
     }
     _checkUseVerifier.checkSimpleIdentifier(node);
+
+    bool isDartCoreRecordVisible =
+        _currentLibrary.featureSet.isEnabled(Feature.records) ||
+            FeatureSet.latestLanguageVersion().isEnabled(Feature.records);
+    Element? staticElement = node.staticElement;
+    if ((staticElement is ClassElement &&
+                staticElement.thisType.isDartCoreRecord ||
+            staticElement is TypeAliasElement &&
+                staticElement.aliasedType.isDartCoreRecord) &&
+        !isDartCoreRecordVisible) {
+      errorReporter.reportErrorForToken(
+          ParserErrorCode.EXPERIMENT_NOT_ENABLED, node.beginToken, [
+        Feature.records.enableString,
+        "${Feature.records.releaseVersion ?? ExperimentStatus.currentVersion}"
+      ]);
+    }
+
     super.visitSimpleIdentifier(node);
   }
 

pkg/front_end/lib/src/fasta/builder/class_builder.dart

@@ -11,6 +11,7 @@ import 'package:kernel/ast.dart'
         DynamicType,
         FutureOrType,
         InterfaceType,
+        InvalidType,
         Member,
         Name,
         NullType,
@@ -346,6 +347,15 @@ abstract class ClassBuilderImpl extends DeclarationBuilderImpl
       int charOffset,
       ClassHierarchyBase? hierarchy,
       {required bool hasExplicitTypeArguments}) {
+    if (name == "Record" &&
+        libraryBuilder.importUri.scheme == "dart" &&
+        libraryBuilder.importUri.path == "core" &&
+        library is SourceLibraryBuilder &&
+        !library.libraryFeatures.records.isEnabled) {
+      library.reportFeatureNotEnabled(
+          library.libraryFeatures.records, fileUri, charOffset, name.length);
+      return const InvalidType();
+    }
     return buildAliasedTypeWithBuiltArguments(
         library,
         nullabilityBuilder.build(library),

pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart

@@ -55,8 +55,7 @@ class ConstructorReferenceBuilder {
         PrefixBuilder prefix = declaration;
         declaration = prefix.lookup(middle, name.charOffset, fileUri);
       } else if (declaration is ClassBuilder) {
-        ClassBuilder cls = declaration;
-        declaration = cls.findConstructorOrFactory(
+        declaration = declaration.findConstructorOrFactory(
             middle, name.charOffset, fileUri, accessingLibrary);
         if (suffix == null) {
           target = declaration;

pkg/front_end/lib/src/fasta/builder/named_type_builder.dart

@@ -4,6 +4,7 @@
 
 library fasta.named_type_builder;
 
+import 'package:front_end/src/fasta/util/helpers.dart';
 import 'package:kernel/ast.dart';
 import 'package:kernel/class_hierarchy.dart';
 import 'package:kernel/src/legacy_erasure.dart';
@@ -408,7 +409,16 @@ abstract class NamedTypeBuilder extends TypeBuilder {
   DartType buildAliased(
       LibraryBuilder library, TypeUse typeUse, ClassHierarchyBase? hierarchy) {
     assert(hierarchy != null || isExplicit, "Cannot build $this.");
-    return _buildAliasedInternal(library, typeUse, hierarchy);
+
+    DartType builtType = _buildAliasedInternal(library, typeUse, hierarchy);
+
+    if (library is SourceLibraryBuilder &&
+        !checkRecordOrItsAliasAccessAllowed(builtType, library)) {
+      library.reportFeatureNotEnabled(library.libraryFeatures.records,
+          fileUri ?? library.fileUri, charOffset!, nameText.length);
+    }
+
+    return builtType;
   }
 
   DartType _buildAliasedInternal(
@@ -695,7 +705,15 @@ class _ExplicitNamedTypeBuilder extends NamedTypeBuilder {
   @override
   DartType build(LibraryBuilder library, TypeUse typeUse,
       {ClassHierarchyBase? hierarchy}) {
-    return _type ??= _buildInternal(library, typeUse, hierarchy);
+    DartType builtType = _buildInternal(library, typeUse, hierarchy);
+
+    if (library is SourceLibraryBuilder &&
+        !checkRecordOrItsAliasAccessAllowed(builtType, library)) {
+      library.reportFeatureNotEnabled(library.libraryFeatures.records,
+          fileUri ?? library.fileUri, charOffset!, nameText.length);
+    }
+
+    return _type ??= builtType;
   }
 }
 

pkg/front_end/lib/src/fasta/builder/prefix_builder.dart

@@ -47,6 +47,7 @@ class PrefixBuilder extends BuilderImpl {
   @override
   Uri get fileUri => parent.fileUri;
 
+  /// Lookup a member with [name] in the export scope.
   Builder? lookup(String name, int charOffset, Uri fileUri) {
     return exportScope.lookup(name, charOffset, fileUri);
   }

pkg/front_end/lib/src/fasta/denylisted_classes.dart

@@ -9,7 +9,8 @@ const List<String> denylistedCoreClasses = [
   "num",
   "double",
   "String",
-  "Null"
+  "Null",
+  "Record",
 ];
 
 // List of special classes in dart:typed_data that can't be subclassed.

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -106,7 +106,7 @@ import '../type_inference/inference_results.dart'
 import '../type_inference/type_inferrer.dart'
     show TypeInferrer, InferredFunctionBody;
 import '../type_inference/type_schema.dart' show UnknownType;
-import '../util/helpers.dart' show DelayedActionPerformer;
+import '../util/helpers.dart';
 import 'collections.dart';
 import 'constness.dart' show Constness;
 import 'constructor_tearoff_lowering.dart';

pkg/front_end/lib/src/fasta/scope.dart

@@ -419,6 +419,7 @@ class Scope extends MutableScope {
     }
   }
 
+  /// Lookup a member with [name] in the scope.
   Builder? lookup(String name, int charOffset, Uri fileUri,
       {bool isInstanceScope = true}) {
     recordUse(name, charOffset);

pkg/front_end/lib/src/fasta/source/source_loader.dart

@@ -2743,6 +2743,8 @@ class int extends num {}
 class num {}
 
 class Function {}
+
+class Record {}
 """;
 
 /// A minimal implementation of dart:async that is sufficient to create an

pkg/front_end/lib/src/fasta/util/helpers.dart

@@ -2,7 +2,31 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:kernel/ast.dart';
+
+import '../source/source_library_builder.dart';
+
 abstract class DelayedActionPerformer {
   bool get hasDelayedActions;
   void performDelayedActions({required bool allowFurtherDelays});
 }
+
+bool checkRecordOrItsAliasAccessAllowed(
+    DartType type, SourceLibraryBuilder accessorLibrary) {
+  Class? targetClass;
+  if (type is InterfaceType) {
+    targetClass = type.classNode;
+  } else if (type is TypedefType) {
+    DartType unaliasedType = type.unalias;
+    if (unaliasedType is InterfaceType) {
+      targetClass = unaliasedType.classNode;
+    }
+  }
+  return accessorLibrary.libraryFeatures.records.isEnabled ||
+      accessorLibrary.libraryFeatures.records.flag.isEnabledByDefault ||
+      !(targetClass != null &&
+          targetClass.parent != null &&
+          targetClass.name == "Record" &&
+          targetClass.enclosingLibrary.importUri.scheme == "dart" &&
+          targetClass.enclosingLibrary.importUri.path == "core");
+}

pkg/front_end/test/spell_checking_list_common.txt

@@ -1257,6 +1257,7 @@ following
 follows
 food
 for
+forbid
 forbidden
 force
 forced
@@ -1388,6 +1389,7 @@ head
 header
 headers
 heading
+heavier
 help
 helper
 helpers

pkg/front_end/test/spell_checking_list_tests.txt

@@ -560,6 +560,7 @@ risky
 rk
 row
 rows
+rr
 runtimes
 rv
 sanitize

pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.expect

@@ -137,6 +137,7 @@ additionalExports = (core::Deprecated,
   core::Object,
   core::Pattern,
   core::Match,
+  core::Record,
   core::RegExp,
   core::RegExpMatch,
   core::Set,

pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.outline.expect

@@ -72,6 +72,7 @@ additionalExports = (core::Deprecated,
   core::Object,
   core::Pattern,
   core::Match,
+  core::Record,
   core::RegExp,
   core::RegExpMatch,
   core::Set,

pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.transformed.expect

@@ -133,6 +133,7 @@ additionalExports = (core::Deprecated,
   core::Object,
   core::Pattern,
   core::Match,
+  core::Record,
   core::RegExp,
   core::RegExpMatch,
   core::Set,

pkg/front_end/testcases/incremental/export_core.yaml.world.2.expect

@@ -50,6 +50,7 @@ additionalExports = (asy::Future,
   core::Pattern,
   core::Provisional,
   core::RangeError,
+  core::Record,
   core::RegExp,
   core::RegExpMatch,
   core::RuneIterator,

pkg/front_end/testcases/incremental/export_core.yaml.world.3.expect

@@ -50,6 +50,7 @@ additionalExports = (asy::Future,
   core::Pattern,
   core::Provisional,
   core::RangeError,
+  core::Record,
   core::RegExp,
   core::RegExpMatch,
   core::RuneIterator,

pkg/front_end/testcases/records/custom_record_class_unsupported.dart

@@ -0,0 +1,11 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// @dart=2.17
+
+abstract class Record {
+  Record create();
+}
+
+main() {}

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.strong.expect

@@ -0,0 +1,11 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+abstract class Record extends core::Object {
+  synthetic constructor •() → self::Record
+    : super core::Object::•()
+    ;
+  abstract method create() → self::Record;
+}
+static method main() → dynamic {}

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.strong.transformed.expect

@@ -0,0 +1,11 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+abstract class Record extends core::Object {
+  synthetic constructor •() → self::Record
+    : super core::Object::•()
+    ;
+  abstract method create() → self::Record;
+}
+static method main() → dynamic {}

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.textual_outline.expect

@@ -0,0 +1,6 @@
+// @dart = 2.17
+abstract class Record {
+  Record create();
+}
+
+main() {}

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.textual_outline_modelled.expect

@@ -0,0 +1,6 @@
+// @dart = 2.17
+abstract class Record {
+  Record create();
+}
+
+main() {}

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.weak.expect

@@ -0,0 +1,11 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+abstract class Record extends core::Object {
+  synthetic constructor •() → self::Record
+    : super core::Object::•()
+    ;
+  abstract method create() → self::Record;
+}
+static method main() → dynamic {}

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.weak.modular.expect

@@ -0,0 +1,11 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+abstract class Record extends core::Object {
+  synthetic constructor •() → self::Record
+    : super core::Object::•()
+    ;
+  abstract method create() → self::Record;
+}
+static method main() → dynamic {}

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.weak.outline.expect

@@ -0,0 +1,11 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+abstract class Record extends core::Object {
+  synthetic constructor •() → self::Record
+    ;
+  abstract method create() → self::Record;
+}
+static method main() → dynamic
+  ;

pkg/front_end/testcases/records/custom_record_class_unsupported.dart.weak.transformed.expect

@@ -0,0 +1,11 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+abstract class Record extends core::Object {
+  synthetic constructor •() → self::Record
+    : super core::Object::•()
+    ;
+  abstract method create() → self::Record;
+}
+static method main() → dynamic {}