Skip to content

[Records] Implement feature in the CFE #49713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
itsjustkevin opened this issue Aug 19, 2022 · 7 comments
Closed

[Records] Implement feature in the CFE #49713

itsjustkevin opened this issue Aug 19, 2022 · 7 comments
Assignees
@johnniwinther
Labels
legacy-area-front-end Legacy: Use area-dart-model instead.
Milestone
Dart 3 beta 3

Comments

@itsjustkevin
Copy link
Contributor

No description provided.

@a-siva a-siva added the legacy-area-front-end Legacy: Use area-dart-model instead. label Aug 19, 2022
@mit-mit
Copy link
Member

mit-mit commented Aug 22, 2022

I think @jensjoha is working on this

@johnniwinther
Copy link
Member

This is a joined effort: @jensjoha is working on the parser (basic implementation is done), @chloestefantsova is adding the new AST nodes, and I'm working on the building the AST nodes from the parser events. When we have a specification, @chloestefantsova will be working on the type inference.

copybara-service bot pushed a commit that referenced this issue Aug 29, 2022
@chloestefantsova
[cfe] Implement subtype relationship for record types
d4a8100 
Part of #49713

Change-Id: I736a4e4f4ba09a80dda1409a1c6640a64ab560f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256480
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
This was referenced Sep 7, 2022
Closed
Closed
Open
copybara-service bot pushed a commit that referenced this issue Sep 15, 2022
@chloestefantsova
[cfe,corelib] Add class 'Record' to the core library
f553f0a 
Part of #49713

Change-Id: Ibb0309f97565c0a623f60e588eefcad6759d5ace
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257066
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 15, 2022
@chloestefantsova
[cfe] Extend UP and DOWN onto record types
dc4c7a1 
Closes #49914

Part of #49713

Change-Id: I49b1ca4ca9b68c8a8dfcdd9d0fc855f173088efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258005
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 15, 2022
@aam
Revert "[cfe,corelib] Add class 'Record' to the core library"
d31c741 
This reverts commit f553f0a

Reason for revert: breaks g3 bot

Original change's description:
> [cfe,corelib] Add class 'Record' to the core library
>
> Part of #49713
>
> Change-Id: Ibb0309f97565c0a623f60e588eefcad6759d5ace
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257066
> Commit-Queue: Chloe Stefantsova <[email protected]>
> Reviewed-by: Johnni Winther <[email protected]>
> Reviewed-by: Konstantin Shcheglov <[email protected]>

[email protected],[email protected],[email protected],[email protected]

Change-Id: If386819fc7419a660c692e4187ead4ebf142c68c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259462
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 16, 2022
@chloestefantsova
Reland "[cfe,corelib] Add class 'Record' to the core library"
4b6a8f3 
Part of #49713

Change-Id: I56bfca49492d14bb561b32993fd9adfe775b7400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259583
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
@alexmarkov alexmarkov mentioned this issue Sep 16, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Sep 19, 2022
@chloestefantsova
Revert "Reland "[cfe,corelib] Add class 'Record' to the core library""
f8ef60a 
This reverts commit 4b6a8f3.

Reason for revert: Breakages in google3.

Original change's description:
> Reland "[cfe,corelib] Add class 'Record' to the core library"
>
> Part of #49713
>
> Change-Id: I56bfca49492d14bb561b32993fd9adfe775b7400
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259583
> Reviewed-by: Johnni Winther <[email protected]>
> Reviewed-by: Slava Egorov <[email protected]>
> Commit-Queue: Chloe Stefantsova <[email protected]>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I61c4db244329615d7d218484cd86601b1c737ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259800
Reviewed-by: Slava Egorov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
Auto-Submit: Chloe Stefantsova <[email protected]>
@alexmarkov alexmarkov mentioned this issue Sep 19, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Sep 26, 2022
@chloestefantsova
[cfe] Add initial implementation of type inference for records
354f144 
Part of #49713

Change-Id: I9208bbfa410fbf6d200e4715ea6171ed58b3510d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260882
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
@alexmarkov alexmarkov mentioned this issue Sep 26, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Oct 4, 2022
@chloestefantsova
[cfe] Implement pointwise implicit downcasts for record literals
7e57f6e 
This CL implements the adjustment of the static semantics for records
as described in
dart-lang/language@d19f6d5. The
adjustment is based on the discussion at
dart-lang/language#2488.

Part of #49713

Change-Id: I7a9d456f702ad0fb14aa3bd121ba9d2bbd104414
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262202
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 4, 2022
@chloestefantsova
Reland "Reland "[cfe,corelib] Add class 'Record' to the core library""
1d768f3 
This is a reland of commit 4b6a8f3

Original change's description:
> Reland "[cfe,corelib] Add class 'Record' to the core library"
>
> Part of #49713
>
> Change-Id: I56bfca49492d14bb561b32993fd9adfe775b7400
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259583
> Reviewed-by: Johnni Winther <[email protected]>
> Reviewed-by: Slava Egorov <[email protected]>
> Commit-Queue: Chloe Stefantsova <[email protected]>

Change-Id: Idaab98c028312ca36bd07f569374ca8b76151a02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260101
Reviewed-by: Slava Egorov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
This was referenced Oct 5, 2022
Closed
Closed
Closed
Closed
copybara-service bot pushed a commit that referenced this issue Oct 6, 2022
@chloestefantsova
[cfe] Account for class Record in constraint gathering
e77f2ee 
Part of #49713

Change-Id: Idfcc304c8da8bb1a6cd887de707ddfd060934543
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262427
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Oct 6, 2022
@chloestefantsova
[cfe] Allow records on the RHS of typedefs
fb0b4a8 
Part of #49713

Closes #50133

Change-Id: I482280599487a3539f88c715e5a92e78f810b264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262962
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Nov 9, 2022
@chloestefantsova
[cfe] Report errors on record named fields clashing with positional
321ea30 
Part of #49713

Closes #50145

Change-Id: Ie825b312095cd2deb74ba0445e9cf1a5f8586790
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268322
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
@eernstg eernstg mentioned this issue Nov 30, 2022
Closed
@itsjustkevin itsjustkevin added this to the Dart 3 beta 2 milestone Feb 6, 2023
@itsjustkevin itsjustkevin removed this from the Dart 3 beta 2 milestone Feb 23, 2023
@itsjustkevin itsjustkevin added this to the Dart 3 beta 3 milestone Feb 23, 2023
@alexmarkov alexmarkov mentioned this issue Mar 17, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Mar 22, 2023
@chloestefantsova
[cfe] Fix the subtyping case of FutureOr and RecordType
472968c 
Closes #51731

Part of #49713

Change-Id: Ie726f2f768df47fd00bd88af1f970ee3a86bf0a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290526
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Lasse Nielsen <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 23, 2023
@chloestefantsova
[cfe] Implement TypeBuilderComputer.visitRecordType
6f6581f 
Closes #51815

Part of #49713

Change-Id: Ib01721765d6112e12d23cd5f8e2990b4c687d732
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290841
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
@itsjustkevin
Copy link
Contributor Author

@chloestefantsova is this still a work in progress?

@chloestefantsova
Copy link
Contributor

To my knowledge, this is implemented. I defer to @johnniwinther to make the call about closing the issue.

@vsmenon
Copy link
Member

vsmenon commented Apr 4, 2023

@johnniwinther - can we close?

@johnniwinther
Copy link
Member

Soon. I have a CL out for #51940 and Paul is looking into #50912 and #50929.

@stereotype441
Copy link
Member

#50912 and #50929 were non-issues (they were old bugs that had since been fixed, but I had neglected to close them). I've closed them now.

@johnniwinther johnniwinther removed the Epic label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
Dart 3 beta 3
Development

No branches or pull requests
7 participants
@stereotype441 @chloestefantsova @vsmenon @a-siva @itsjustkevin @johnniwinther @mit-mit