[element model] migrate avoid_renaming_method_parameters

Interestingly this fixes a few false negatives that are showing up on the bots:

Flutter:

https://github.com/flutter/packages/blob/main/packages/vector_graphics_compiler/lib/src/svg/visitor.dart#L48

Dart:

https://dart-review.googlesource.com/c/sdk/+/394569




Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I1ff221bd8591d712caaaa24f15d065bf8b2426ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394662
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/lib/src/rules/avoid_renaming_method_parameters.dart

@@ -5,9 +5,10 @@
 import 'dart:math' as math;
 
 import 'package:analyzer/dart/analysis/features.dart';
-import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
+// ignore: implementation_imports
+import 'package:analyzer/src/dart/ast/ast.dart';
 
 import '../analyzer.dart';
 import '../extensions.dart';
@@ -29,7 +30,8 @@ class AvoidRenamingMethodParameters extends LintRule {
       NodeLintRegistry registry, LinterContext context) {
     if (!context.isInLibDir) return;
 
-    var visitor = _Visitor(this, context.libraryElement);
+    var visitor =
+        _Visitor(this, context.libraryElement2, context.inheritanceManager);
     registry.addMethodDeclaration(this, visitor);
   }
 }
@@ -38,9 +40,11 @@ class _Visitor extends SimpleAstVisitor<void> {
   /// Whether the `wildcard_variables` feature is enabled.
   final bool _wildCardVariablesEnabled;
 
+  final InheritanceManager3 inheritanceManager;
+
   final LintRule rule;
 
-  _Visitor(this.rule, LibraryElement? library)
+  _Visitor(this.rule, LibraryElement2? library, this.inheritanceManager)
       : _wildCardVariablesEnabled =
             library?.featureSet.isEnabled(Feature.wildcard_variables) ?? false;
 
@@ -52,50 +56,47 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (node.isStatic) return;
     if (node.documentationComment != null) return;
 
-    var parentNode = node.parent;
-    if (parentNode is! Declaration) {
-      return;
-    }
-    var parentElement = parentNode.declaredElement;
-    // Note: there are no override semantics with extension methods.
-    if (parentElement is! InterfaceElement) {
-      return;
-    }
+    var nodeParams = node.parameters;
+    if (nodeParams == null) return;
 
-    var classElement = parentElement;
+    late List<FormalParameterElement> parentParameters;
 
-    if (classElement.isPrivate) return;
+    var previousFragment = node.declaredFragment?.previousFragment;
+    if (previousFragment == null) {
+      // If it's the first fragment, check for an inherited member.
+      var parentNode = node.parent;
+      if (parentNode is! Declaration) return;
 
-    var parentMethod = classElement.lookUpInheritedMethod(
-        node.name.lexeme, classElement.library);
+      var parentElement = parentNode.declaredFragment?.element;
 
-    // If it's not an inherited method, check for an augmentation.
-    if (parentMethod == null && node.isAugmentation) {
-      var element = node.declaredElement;
-      // Note that we only require an augmentation to conform to the previous
-      // declaration/augmentation in the chain.
-      var target = element?.augmentationTarget;
-      if (target is MethodElement) {
-        parentMethod = target;
-      }
-    }
+      // Note: there are no override semantics with extension methods.
+      if (parentElement is! InterfaceElement2) return;
+      if (parentElement.isPrivate) return;
 
-    if (parentMethod == null) return;
+      var parentMethod = inheritanceManager.getMember4(
+          parentElement, Name(parentElement.library2.uri, node.name.lexeme),
+          forSuper: true);
+      if (parentMethod == null) return;
 
-    var nodeParams = node.parameters;
-    if (nodeParams == null) {
-      return;
+      parentParameters = parentMethod.formalParameters.positional;
+    } else {
+      if (!node.isAugmentation) return;
+
+      parentParameters =
+          previousFragment.formalParameters.map((p) => p.element).positional;
     }
 
     var parameters = nodeParams.parameters.where((p) => !p.isNamed).toList();
-    var parentParameters =
-        parentMethod.parameters.where((p) => !p.isNamed).toList();
+
     var count = math.min(parameters.length, parentParameters.length);
     for (var i = 0; i < count; i++) {
       if (parentParameters.length <= i) break;
 
-      var parentParameterName = parentParameters[i].name;
-      if (isWildcardIdentifier(parentParameterName)) continue;
+      var parentParameterName = parentParameters[i].name3;
+      if (parentParameterName == null ||
+          isWildcardIdentifier(parentParameterName)) {
+        continue;
+      }
 
       var parameterName = parameters[i].name;
       if (parameterName == null) continue;
@@ -110,3 +111,8 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
   }
 }
+
+extension on Iterable<FormalParameterElement> {
+  List<FormalParameterElement> get positional =>
+      where((p) => !p.isNamed).toList();
+}