Skip to content

☂️ [meta] migrate the linter to the new element model #59548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Sep 26, 2024 · 2 comments
Closed

☂️ [meta] migrate the linter to the new element model #59548

pq opened this issue Sep 26, 2024 · 2 comments
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task

Comments

@pq
Copy link
Member

pq commented Sep 26, 2024 •
edited
Loading

A tracking issue for the linter new element model migration.
@pq pq self-assigned this Sep 26, 2024
@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task labels Sep 26, 2024
@bwilkerson
Copy link
Member

Would it be better to track this all in the spreadsheet so that the information is in one place?

copybara-service bot referenced this issue Sep 26, 2024
@pq
[element model] migrate always_specify_types
c580044 
See: https://github.com/dart-lang/linter/issues/5099

Change-Id: Ia76a8d32a526b2f7dd5f537f836a044901a1f108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387140
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate no_leading_underscores_for_library_prefixes
dcb771c 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I03bef84eca282359a3f776870c78cad22ff9aa24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386728
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate prefer_collection_literals
5ca26de 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I0fea39fc55c60b0a388979ffb5b0b00a507fc500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386967
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate library_prefixes
8448628 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I951d4d9152e0854ee316a301e693603c51c2162d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386727
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate avoid_catches_without_on_clauses
2015686 
See: https://github.com/dart-lang/linter/issues/5099

Change-Id: I32c758c76df7e80c465efb13dacf3ebd4854e9a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387141
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate avoid_shadowing_type_parameters
f390204 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I803413fb03956c89d6183c8cb4bf9872c8b60590
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386968
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate unnecessary_null_aware_assignments
118897c 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I43f854025a1bd73d5df7558e6e195ab68d229eea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387300
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate tighten_type_of_initializing_formals
ae6b4b6 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I8e540237743629b314d1439270b9fc0a33437f48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386970
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate unnecessary_parenthesis
9db9580 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ic0e42a86bcab608ff47f7e7911b8909b7d93c8f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387124
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate avoid_double_and_int_checks
dfe15b1 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I36f41cc74a2050fd3a87d33ff6103741e7d40deb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386726
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate unnecessary_statements
01cc385 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ia91e1dc12038414b62c4975de3c2ee4769017b5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387129
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate discarded_futures
c69898a 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I1034c5daf88a33f2d8a18fa8dc01d9e2de10e942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387321
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 27, 2024
@pq
[element model] migrate avoid_slow_async_io
645a619 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I4f67ae413031d5bd8a848fa28aee634e481ab4be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387132
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate always_put_required_named_parameters_first
c7bb518 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I21e9a684b803704b315d3fd1671c919c6cddc138
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387359
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate file_names
3b22c6d 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I8699e2feca0e96db17cd149d2fd398fce32a8a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387620
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate use_truncating_division
76d5d2a 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ic8ee0ed94d0e796a4feb38e26263b4ae72a5ff67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387621
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate valid_regexps
a4dcd25 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I447de40607f9ef4fd49b80c406b75285b28839f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387604
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate eol_at_end_of_file
23b1155 
Bug: ihttps://github.com/dart-lang/linter/issues/5099
Change-Id: Ic5d34042543f561b19a4f73ae17a1d375ba69757
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387624
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate comment_references
4a632a3 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ia0957f65ee9bfd49b1984849d9a2df6bef476552
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387606
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate document_ignores
4334ac9 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ib2a67357d403b5741ac28b72676334135e03b3d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387607
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate do_not_use_environment
c5684c4 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ided4b129486fd0d394547a69303613db129c66af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387625
Commit-Queue: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Sep 30, 2024
@pq
[element model] migrate unnecessary_breaks
72ee3e9 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I745a770eecd901a1eb56acc5043939eccb8ebb91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387660
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Oct 1, 2024
@pq
[element model] migrate lines_longer_than_80_chars
fa5435b 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I55abada2367bf5416605b7394cfec9d105c30371
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387611
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Oct 1, 2024
@pq
[element model] migrate no_wildcard_variable_uses
eae93ca 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I2fe338250a9b24891f142a73b174f9ee2bf0ae7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387528
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Oct 3, 2024
@pq
[element model] migrate missing_whitespace_between_adjacent_strings
c514eb5 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I1c30a693d717977e4ea5956400c891af4c6a7962
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388140
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Oct 3, 2024
@pq
[element model] fix no_wildcard_variable_uses migration
7b3718c 
Bug: https://github.com/dart-lang/linter/issues/5099

Change-Id: Ibde9394aa21fd4d81242e51cfad3f6166c1b2653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388044
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Nov 8, 2024
@pq
[element model] migrate unreachable_from_main
25f8cc5 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I31ee1aff4cbca63b8b66d6fe31a6e901d104fa71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394005
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Nov 11, 2024
@pq
[element model] migrate cascade_invocations
9a76ff8 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ic70839e4c56da27fbc7b3e336d790605e1cf97c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394600
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Nov 11, 2024
@pq
[element model] migrate avoid_types_as_parameter_names
0095085 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I279df798db88bec35276e5e0c66793da9d45fde0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394601
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Nov 11, 2024
@pq
[element model] migrate unnecessary_this
e0e4b41 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I46c62d689518c1091d4aa9262b6939948f6be515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394562
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Nov 12, 2024
@pq
[element model] migrate use_key_in_widget_constructors
104f455 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I2355eda7d2516137f4bb31b12dc5403e3c003295
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390502
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Nov 12, 2024
@pq
[element model] migrate use_setters_to_change_properties
07148b7 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I456c6e950c745f5f41bfba5d131e991d2435f713
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394385
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Nov 12, 2024
@pq
[element model] migrate leak_detector
0f4883e 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I884c138719f046f641bf601f8be4e46a8348fe47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394387
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Nov 13, 2024
@pq
[element model] migrate avoid_renaming_method_parameters
c94bad5 
Interestingly this fixes a few false negatives that are showing up on the bots:

Flutter:

https://github.com/flutter/packages/blob/main/packages/vector_graphics_compiler/lib/src/svg/visitor.dart#L48

Dart:

https://dart-review.googlesource.com/c/sdk/+/394569




Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I1ff221bd8591d712caaaa24f15d065bf8b2426ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394662
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Nov 13, 2024
@pq
[element model] migrate scope_util_test
7784976 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I3a1a0229b59a7b9f83011d0acd6fd6d56415c5ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394840
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot referenced this issue Nov 13, 2024
@pq
[element model] migrate scope
d3de4d9 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I85deb22dbe24f024ea69643dc4a3b30348a7fbad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394880
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Nov 13, 2024
@pq
[element model] migrate avoid_void_async
5297291 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I9b7f68540c3a950ddd673da7eac04e9c2cdc1614
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390782
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot referenced this issue Nov 13, 2024
@pq
[element model] migrate public_member_api_docs
edc2536 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I3a215df3bd3c01b58b0ca9c698f0f888fe5e9cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395121
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 20, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 20, 2024
copybara-service bot pushed a commit that referenced this issue Dec 2, 2024
@pq
[element model] migrate prefer_final_fields
05130dc 
Bug: #59548
Change-Id: I7dac3c262d904f6fc2c69e09d90e17749962eb61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397060
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 2, 2024
@pq
[element model] migrate prefer_asserts_in_initializer_lists
c54255f 
Bug: #59548
Change-Id: I8ff2f686171311d22e4e2c1b1203dc492102aaff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398502
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 3, 2024
@pq
[element model] migrate avoid_setters_without_getters
a013505 
Bug:  #59548
Change-Id: Ie5d17b153821a802e694b376c54d3a36bdd7e8d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398503
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 3, 2024
@pq
[element model] migrate ast utils
546eff8 
Bug: #59548
Change-Id: Ibb2abbebcac8b360669f16ae344b45a4763dfee2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398603
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 4, 2024
@pq
[element model] migrate prefer_initializing_formals
8b29a61 
Bug: #59548
Change-Id: I8a510f82c5a938610d7f46b85fcf3f906bbb700e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398920
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 5, 2024
@pq
[element model] migrate use_build_context_synchronously
c32c0b8 
Bug: #59548
Change-Id: I25f21ad60ae3a1e436cf692b09adacebe5ac44d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398805
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 5, 2024
@pq
[element model] migrate dart_type_utilities
391cec1 
Bug: #59548
Change-Id: I97c256658d374e141fac2e0f9a571d2b0c4ef9c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399262
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 5, 2024
@pq
[element model] migrate unnecessary_overrides
981e560 
Bug: #59548
Change-Id: Ic21505fb6acda2279a3d51f6000f2cc50924c07a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399104
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 5, 2024
@pq
[element model] migrate invalid_runtime_check_with_js_interop_types
cf1f51e 
Bug: #59548
Change-Id: I61a8ba2868503ca36b4211378e3510d9791014d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399260
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 5, 2024
@pq
[element model] cleanup extensions (partial)
935a985 
Bug: #59548
Change-Id: I46d1bc371ca05bac98c112eb0122c5a71af914ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399280
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 6, 2024
@pq
[element model] migrate use_late_for_private_fields_and_variables
09d02b9 
Bug: #59548
Change-Id: Id6e4dc7e93d4da931e4ad4c3dc373651258b746c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398947
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 6, 2024
@pq
[element model] migrate extensions (final)
d74ead2 
Bug: #59548
Change-Id: I06ea96988409f69bdcdf67fd9a40278a64c170af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399500
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 6, 2024
@pq
[element model] remove ignore-list
7811f8d 
And with that, the linter is complete!

Bug: #59548
Change-Id: Iae72831f92ad4ac9b48e7b2a257dad69cec4683d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399028
Commit-Queue: Phil Quitslund <[email protected]>
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
@pq
Copy link
Member Author

pq commented Dec 10, 2024

Complete as of 7811f8d 🎉

@pq pq closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @devoncarew @bwilkerson