[cfe] Allow records on the RHS of typedefs

Part of #49713

Closes #50133

Change-Id: I482280599487a3539f88c715e5a92e78f810b264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262962
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/fasta/source/source_type_alias_builder.dart

@@ -9,12 +9,9 @@ import 'package:kernel/class_hierarchy.dart';
 
 import '../builder/builder.dart';
 import '../builder/class_builder.dart';
-import '../builder/fixed_type_builder.dart';
-import '../builder/function_type_builder.dart';
 import '../builder/library_builder.dart';
 import '../builder/member_builder.dart';
 import '../builder/metadata_builder.dart';
-import '../builder/named_type_builder.dart';
 import '../builder/type_alias_builder.dart';
 import '../builder/type_builder.dart';
 import '../builder/type_declaration_builder.dart';
@@ -88,17 +85,6 @@ class SourceTypeAliasBuilder extends TypeAliasBuilderImpl {
 
   Typedef build() {
     buildThisType();
-
-    TypeBuilder type = this.type;
-    if (type is FunctionTypeBuilder ||
-        type is NamedTypeBuilder ||
-        type is FixedTypeBuilder) {
-      // No error, but also no additional setup work.
-      // ignore: unnecessary_null_comparison
-    } else if (type != null) {
-      unhandled("${type.fullNameForErrors}", "build", charOffset, fileUri);
-    }
-
     return typedef;
   }
 

pkg/front_end/testcases/records/issue50133.dart

@@ -0,0 +1,11 @@
+// Copyright (c) 2022, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+typedef Foo = (int, int);
+
+test() {
+  Foo x = (1, 2);
+}
+
+main() {}

pkg/front_end/testcases/records/issue50133.dart.strong.expect

@@ -0,0 +1,9 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+typedef Foo = (core::int, core::int);
+static method test() → dynamic {
+  (core::int, core::int) x = (1, 2);
+}
+static method main() → dynamic {}

pkg/front_end/testcases/records/issue50133.dart.strong.transformed.expect

@@ -0,0 +1,14 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+typedef Foo = (core::int, core::int);
+static method test() → dynamic {
+  (core::int, core::int) x = (1, 2);
+}
+static method main() → dynamic {}
+
+
+Extra constant evaluation status:
+Evaluated: RecordLiteral @ org-dartlang-testcase:///issue50133.dart:8:11 -> RecordConstant(const (1, 2))
+Extra constant evaluation: evaluated: 1, effectively constant: 1

pkg/front_end/testcases/records/issue50133.dart.textual_outline.expect

@@ -0,0 +1,3 @@
+typedef Foo = (int, int);
+test() {}
+main() {}

pkg/front_end/testcases/records/issue50133.dart.weak.expect

@@ -0,0 +1,9 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+typedef Foo = (core::int, core::int);
+static method test() → dynamic {
+  (core::int, core::int) x = (1, 2);
+}
+static method main() → dynamic {}

pkg/front_end/testcases/records/issue50133.dart.weak.modular.expect

@@ -0,0 +1,9 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+typedef Foo = (core::int, core::int);
+static method test() → dynamic {
+  (core::int, core::int) x = (1, 2);
+}
+static method main() → dynamic {}

pkg/front_end/testcases/records/issue50133.dart.weak.outline.expect

@@ -0,0 +1,9 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+typedef Foo = (core::int, core::int);
+static method test() → dynamic
+  ;
+static method main() → dynamic
+  ;

pkg/front_end/testcases/records/issue50133.dart.weak.transformed.expect

@@ -0,0 +1,14 @@
+library /*isNonNullableByDefault*/;
+import self as self;
+import "dart:core" as core;
+
+typedef Foo = (core::int, core::int);
+static method test() → dynamic {
+  (core::int, core::int) x = (1, 2);
+}
+static method main() → dynamic {}
+
+
+Extra constant evaluation status:
+Evaluated: RecordLiteral @ org-dartlang-testcase:///issue50133.dart:8:11 -> RecordConstant(const (1, 2))
+Extra constant evaluation: evaluated: 1, effectively constant: 1

pkg/front_end/testcases/textual_outline.status

@@ -146,6 +146,7 @@ rasta/malformed_const_constructor: FormatterCrash
 rasta/mandatory_parameter_initializer: FormatterCrash
 records/access_through_type_variable: FormatterCrash
 records/const_record_literal: FormatterCrash
+records/issue50133: FormatterCrash
 records/record_literal_errors: FormatterCrash
 records/record_type: FormatterCrash
 records/record_type_errors: FormatterCrash