Skip to content

Test NamedParametersWithObjectPropertyNamesTest.dart is illegal dart code #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Mar 13, 2012 · 5 comments
Closed

Test NamedParametersWithObjectPropertyNamesTest.dart is illegal dart code #2137

DartBot opened this issue Mar 13, 2012 · 5 comments
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).

Comments

@DartBot
Copy link

DartBot commented Mar 13, 2012

This issue was originally filed by @mhausner

Test language/src/NamedParametersWithObjectPropertyNamesTest.dart contains several
methods that have optional named arguments that start with and underscore.

The language spec says:

 It is a compile-time error if the name of a named optional parameter begins with an ‘_’ character.
@madsager
Copy link
Contributor

Added Triaged label.

@DartBot
Copy link
Author

DartBot commented Jun 11, 2012

This comment was originally written by [email protected]

Issue #3495 has been merged into this issue.

@whesse
Copy link
Contributor

whesse commented Jun 15, 2012

Moved issues with specific language tests to the area "Language". These tests should be fixed by the language deciders and implementers.

Removed Area-Test label.
Added Area-Language label.

@srawlins
Copy link
Member

This can be closed. tests/language/named_parameters_with_object_property_names_test.dart no longer has any named optional parameters that begin with a _.

@DartBot
Copy link
Author

DartBot commented Aug 18, 2014

This comment was originally written by @mhausner

Indeed.

Added Verified label.

@DartBot DartBot added Type-Defect area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Aug 18, 2014
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
copybara-service bot pushed a commit that referenced this issue Jun 12, 2023
@devoncarew
[deps] rev dartdoc, http, mockito, webdev
f1274fd 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/2a39574..5799424):
  57994242  2023-06-09  Parker Lougheed  Remove old <nodoc> syntax (#3261)

http (https://github.com/dart-lang/http/compare/5312366..ba7eb60):
  ba7eb60  2023-06-09  Brian Quinlan  Run common URLSessionTask tests on URLSessionWebSocketTask (#959)
  1746017  2023-06-09  Brian Quinlan  Support delegate methods for WebSocketTask (#958)

mockito (https://github.com/dart-lang/mockito/compare/cca4858..1d6064a):
  1d6064a  2023-06-09  Nate Bosch  Prepare to publish

webdev (https://github.com/dart-lang/webdev/compare/a6d761d..81ae77a):
  81ae77aa  2023-06-09  Elliott Brooks  Update Dart Debug Extension version in preparation for publishing (#2139)
  bb9265a0  2023-06-09  Elliott Brooks  Update DCM workflow (#2135)
  7652f646  2023-06-09  Elliott Brooks  Double the timeout for the webdev installation test (#2137)

Change-Id: I9d775bbb5c8a710a3339fa3434a95e8e0f2af75c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308760
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @madsager @whesse @DartBot