Skip to content

Sanitization throws on embed elements in Firefox #23466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alan-knight opened this issue May 14, 2015 · 1 comment
Closed

Sanitization throws on embed elements in Firefox #23466

alan-knight opened this issue May 14, 2015 · 1 comment
Assignees
@alan-knight
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. closed-obsolete Closed as the reported issue is no longer relevant library-html P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@alan-knight
Copy link
Contributor

An embed element in Firefox is not an object, the typeof says Function. As a result we don't get an interceptor for it and it doesn't have methods. We probably need to drop down into JS to see if it's a reasonable element or not. We may be able to just outright reject <embed>. See, e.g. co19/LayoutTests/fast/loader/loadInProgress_t01
@alan-knight alan-knight added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels May 14, 2015
@alan-knight alan-knight self-assigned this May 14, 2015
@alan-knight alan-knight mentioned this issue Dec 7, 2015
Open
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@vsmenon vsmenon added area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. closed-obsolete Closed as the reported issue is no longer relevant labels Jul 20, 2019
@vsmenon
Copy link
Member

vsmenon commented Jul 22, 2019

Closing as obsolete as I don't think anyone's hit this in years.

@vsmenon vsmenon closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alan-knight alan-knight

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. closed-obsolete Closed as the reported issue is no longer relevant library-html P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @vsmenon @alan-knight