-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Object and Embed elements are JS functions in Firefox and Chrome 47, so dart2js does not find interceptors for them #25155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note: tests that fail because of this are marked Pass, RuntimeError while we have some bots on 46 and others on 47. This should be fixed once they're all updated. |
All the bots are on 47 now and the tests are properly marked RuntimeError. |
@alan-knight what else remains here? I noted the bug is not assigned to anyone. |
This high priority bug should be assigned to someone on the dart2js html library team, or it shouldn't be high priority. |
The high priority original problem now has a workaround, so we can probably remove this from high priority. |
Moving to 1.15 |
@alan-knight could you give the link or example of this workaround? |
As I remember, the issue was setting some content through Angular, so it was going through setting innerHtml, which meant that it was getting touched by Dart code, although it didn't need to be. So there are a few possible workarounds. One is don't use that element :-). Another is that if it's in static HTML and you're not programmatically manipulating it through Dart it shouldn't be a problem. I think that even if you go through setting innerHtml/appendHtml/etc, if it's HTML that you control and you can use NodeTreeSanitizer.trusted, then that should work. And I guess the last-ditch workaround is write a fragment of JS to do the work you need to do on that element and invoke it from Dart. |
possible duplicate #25785 ? |
Yes, I think that's the same underlying issue. |
Clearing out 1.15 milestone as the last full push to dev has happened. If any changes are required before 1.15 is shipped, please file a merge request |
Same root cause as #23466 but more general.
@rakudrama
The text was updated successfully, but these errors were encountered: