Skip to content

Object and Embed elements are JS functions in Firefox and Chrome 47, so dart2js does not find interceptors for them #25155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alan-knight opened this issue Dec 7, 2015 · 11 comments
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. dart2js-interceptors P2 A bug or feature request we're likely to work on web-dart2js web-libraries Issues impacting dart:html, etc., libraries

Comments

@alan-knight
Copy link
Contributor

Same root cause as #23466 but more general.
@rakudrama

@alan-knight alan-knight added P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js web-libraries Issues impacting dart:html, etc., libraries labels Dec 7, 2015
@alan-knight alan-knight added this to the 1.14 milestone Dec 7, 2015
@alan-knight
Copy link
Contributor Author

Note: tests that fail because of this are marked Pass, RuntimeError while we have some bots on 46 and others on 47. This should be fixed once they're all updated.

@alan-knight
Copy link
Contributor Author

All the bots are on 47 now and the tests are properly marked RuntimeError.

@mit-mit
Copy link
Member

mit-mit commented Jan 14, 2016

@alan-knight what else remains here? I noted the bug is not assigned to anyone.

@whesse
Copy link
Contributor

whesse commented Jan 20, 2016

This high priority bug should be assigned to someone on the dart2js html library team, or it shouldn't be high priority.

@alan-knight
Copy link
Contributor Author

The high priority original problem now has a workaround, so we can probably remove this from high priority.

@alan-knight alan-knight added Priority-Medium and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jan 20, 2016
@mit-mit
Copy link
Member

mit-mit commented Jan 20, 2016

Moving to 1.15

@mit-mit mit-mit modified the milestones: 1.15, 1.14 Jan 20, 2016
@denisoby
Copy link

@alan-knight could you give the link or example of this workaround?

@alan-knight
Copy link
Contributor Author

As I remember, the issue was setting some content through Angular, so it was going through setting innerHtml, which meant that it was getting touched by Dart code, although it didn't need to be. So there are a few possible workarounds. One is don't use that element :-). Another is that if it's in static HTML and you're not programmatically manipulating it through Dart it shouldn't be a problem. I think that even if you go through setting innerHtml/appendHtml/etc, if it's HTML that you control and you can use NodeTreeSanitizer.trusted, then that should work. And I guess the last-ditch workaround is write a fragment of JS to do the work you need to do on that element and invoke it from Dart.

@DisDis
Copy link

DisDis commented Feb 16, 2016

possible duplicate #25785 ?

@alan-knight
Copy link
Contributor Author

Yes, I think that's the same underlying issue.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed Priority-Medium labels Mar 1, 2016
@mit-mit
Copy link
Member

mit-mit commented Mar 2, 2016

Clearing out 1.15 milestone as the last full push to dev has happened. If any changes are required before 1.15 is shipped, please file a merge request

@mit-mit mit-mit modified the milestones: 1.16, 1.15 Mar 2, 2016
@mit-mit mit-mit removed this from the 1.16 milestone Apr 21, 2016
@vsmenon vsmenon added the area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. dart2js-interceptors P2 A bug or feature request we're likely to work on web-dart2js web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

8 participants