Skip to content

Implement proper shell escaping for pub command error reproduction #23505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whesse opened this issue May 22, 2015 · 1 comment
Closed

Implement proper shell escaping for pub command error reproduction #23505

whesse opened this issue May 22, 2015 · 1 comment
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@whesse
Copy link
Contributor

whesse commented May 22, 2015

Error reporting from pub includes printing a command line to rerun the failing command. The arguments need to be properly escaped, depending on the shell (OS) that is running. We currently put double quotes around any argument containing spaces.
@whesse whesse added Type-Enhancement P3 A lower priority bug or feature request labels May 22, 2015
@DartBot DartBot mentioned this issue Jun 4, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 4, 2015

This issue has been moved to dart-lang/pub#28.

@DartBot DartBot closed this as completed Jun 4, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @whesse @DartBot