Skip to content

Implement proper shell escaping for pub command error reproduction #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Jun 4, 2015 · 3 comments · Fixed by #2093
Closed

Implement proper shell escaping for pub command error reproduction #28

DartBot opened this issue Jun 4, 2015 · 3 comments · Fixed by #2093
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/4905639?v=3" align="left" width="96" height="96"hspace="10"> Issue by whesse
Originally opened as dart-lang/sdk#23505

Error reporting from pub includes printing a command line to rerun the failing command. The arguments need to be properly escaped, depending on the shell (OS) that is running. We currently put double quotes around any argument containing spaces.
@DartBot DartBot added type-enhancement A request for a change that isn't a bug Priority-Low labels Jun 4, 2015
@DartBot DartBot mentioned this issue Jun 4, 2015
Closed
@nex3
Copy link
Member

nex3 commented Jun 5, 2015

Duplicate of #1207.

@nex3 nex3 closed this as completed Jun 5, 2015
@selkhateeb
Copy link

@nex3 if this is closed, any reason why the TODO line still exists in

pub/lib/src/command_runner.dart

Line 179 in 73ff0d3

// TODO(23505): Implement proper shell escaping, not a partial hack.

@nex3
Copy link
Member

nex3 commented Mar 9, 2018

This probably shouldn't have been closed. It was merged with #1207, but technically that had a narrower scope.

@nex3 nex3 reopened this Mar 9, 2018
@rwrozelle rwrozelle mentioned this issue Mar 21, 2018
Closed
@Rushabhshroff Rushabhshroff mentioned this issue Apr 28, 2018
Closed
jonasfj added a commit to jonasfj/pub that referenced this issue Mar 5, 2019
@jonasfj
Fix dart-lang#28 -- escaping arguments as mentioned in TODO
03eb656
@jonasfj jonasfj mentioned this issue Mar 5, 2019
Merged
jonasfj added a commit that referenced this issue Mar 7, 2019
@jonasfj
Fix #28 -- escaping arguments as mentioned in TODO
feb1276
jonasfj added a commit that referenced this issue Mar 8, 2019
@jonasfj
Fix #28 -- escaping arguments as mentioned in TODO (#2093)
154a141
@gooking gooking mentioned this issue Sep 5, 2019
Closed
sigurdm pushed a commit to sigurdm/pub that referenced this issue Nov 15, 2019
@kevmoo
Remove redundant PubSummary.lockedVersion (dart-lang#28)
75a6d0d 
Remove redundant PubSummary.lockedVersion
But keep the logic around to validate the pub output parsing
@WangZhen0908 WangZhen0908 mentioned this issue Jun 18, 2021
Closed
@sigurdm sigurdm added P3 A lower priority bug or feature request and removed low priority labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #28 -- escaping arguments as mentioned in TODO jonasfj/pub
4 participants
@nex3 @selkhateeb @sigurdm @DartBot